Add GX6 communication dongle support #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electron wasn't installed as a dev dependency, leading to errors when trying to run it and would require installing electron globally (not ideal). Also cleaned up package.json with leftover code from BracketBrowser
Getting ready to add support for GX6 dongle
Slightly restructured script, can now access some data outside the dongle.js Still need to create more methods to export (eg setting individual tracker settings)
idk why this kinda triggered me lol gotta follow camelCaseConventionsFr though some users who set it might have their smoothinput setting reset
me when inconsistent
forgot about index.js
Final commit for using camelCase for consistency :p i hope this doesn't screw me up with merge conflicts later on.
this took me forever fixing bugs. please help. i've been at this for hours.
i hate merge conflicts. i feel like everything broke faksd
|
Been working on a NPM package with improved code - will implement support with new PR when it's done soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the GX6 communication dongle, modifying my proof-of-concept script made in Python and converting it to JavaScript while adding features required for the program to support it.
PR also includes some QOL and maintenance changes.