Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic_include to include the generated file dune.inc #1199

Merged
merged 6 commits into from
Aug 9, 2024

Commits on Aug 9, 2024

  1. Use dynamic_include to include the generated file dune.inc

    This PR uses the new feature `dynamic_include` to include our generated
    file `dune.inc`.
    
    Pros:
    - We do not upstream `dune.inc` anymore!
    - The output of `dune.inc` depends on the plateform. This is the main
      motivation of this PR because Windows does not use the convention for
      path.
    
    Cons:
    - We need `Dune > 3.14`
    - We cannot use the stanza `subdir` in `dune.inc`, which means we have
      to ensure we do not use twice the same name for two tests even if
      there are not in the same directory. See issue
      ocaml/dune#10405
    Halbaroth committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    6dc7046 View commit details
    Browse the repository at this point in the history
  2. update js workflow

    Halbaroth committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    89768d7 View commit details
    Browse the repository at this point in the history
  3. review changes

    Halbaroth committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    376b485 View commit details
    Browse the repository at this point in the history
  4. poetry

    Halbaroth committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ee6c930 View commit details
    Browse the repository at this point in the history
  5. review changes 2

    Halbaroth committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    fceb48d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d58489e View commit details
    Browse the repository at this point in the history