Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the compilation error about the missing primitive
unix_gettimeoftheday
. Since the release 4.1.0 ofjs_of_ocaml
, the function has been renamed ascaml_unix_gettimeoftheday
. See ocsigen/js_of_ocaml#1370.make js
.--no-source-map
for the release profile only. Indeed, according to thejs_of_ocaml
documentation, producing a mapping between the OCaml source and the generated Javascript gives a bigger and slower binary. Yet, the option could be useful for debugging purposes.make
:This error is produced during the compilation with
js_of_ocaml
of theZarith
library. The warning oddly disappears if we turn off the separation compilation injs_of_ocaml
but we got a bunch of new warning messages about missing primitives: