-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up OptimAE #921
Clean up OptimAE #921
Commits on Dec 5, 2023
-
Removing the optimization support in the native language
The current implementation of `maximize` and `minimize` isn't satisfying in the native language. As this feature have never been released and MERCE prefers using the SMT-LIB format, we remove the support of optimization in the native language.
Configuration menu - View commit details
-
Copy full SHA for ea784c0 - Browse repository at this point
Copy the full SHA ea784c0View commit details -
This PR refactors the way we manage optimization constraints in Alt-Ergo. - Optimization constraints aren't tag on subformulas anymore. Instead we use the MaxSMT syntaxes. - We don't support optimization in Alt-Ergo native format. As this feature haven't been published, we don't need to deprecated it. - We support `maximize`, `minimize` and `get-objectives`. There is no support for `assert-soft`. I think it's out of the scope of this PR. - The SAT solver API exposes two new functions: `optimize` and `get_objectives` which, respectively, register objective function and return the current objective model. - The objective values are expressions.
Configuration menu - View commit details
-
Copy full SHA for d3fdb3d - Browse repository at this point
Copy the full SHA d3fdb3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf11411 - Browse repository at this point
Copy the full SHA cf11411View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08e413f - Browse repository at this point
Copy the full SHA 08e413fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9f8a25 - Browse repository at this point
Copy the full SHA f9f8a25View commit details -
Configuration menu - View commit details
-
Copy full SHA for b648a22 - Browse repository at this point
Copy the full SHA b648a22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 791c2f7 - Browse repository at this point
Copy the full SHA 791c2f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97fb30e - Browse repository at this point
Copy the full SHA 97fb30eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a850678 - Browse repository at this point
Copy the full SHA a850678View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fbc6d3 - Browse repository at this point
Copy the full SHA 0fbc6d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9737a61 - Browse repository at this point
Copy the full SHA 9737a61View commit details -
Configuration menu - View commit details
-
Copy full SHA for d395e69 - Browse repository at this point
Copy the full SHA d395e69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8482427 - Browse repository at this point
Copy the full SHA 8482427View commit details -
The optimization constraint is wrong if we use it in incremental mode but it's safe if we use `maximize` and `minimize` at the top level only.
Configuration menu - View commit details
-
Copy full SHA for 0927911 - Browse repository at this point
Copy the full SHA 0927911View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d28004 - Browse repository at this point
Copy the full SHA 7d28004View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5452cfc - Browse repository at this point
Copy the full SHA 5452cfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8775e68 - Browse repository at this point
Copy the full SHA 8775e68View commit details -
Propagate value produced by
middle_value
The value produced by `middle_value` in `intervalCalculus` wasn't propagate to the CC(X) module in `look_for_sat`. We propagate it now. I also modify the test `arith7.optimize.smt2` as we cannot use both incremental mode and optimization constraints.
Configuration menu - View commit details
-
Copy full SHA for 9170dc7 - Browse repository at this point
Copy the full SHA 9170dc7View commit details -
Prevent impure terms in MaxSMT statements
We don't support yet impure terms or formulae in `maximize` and `minimize` statements. Let's print a warning message and ignoring invalid objective functions.
Configuration menu - View commit details
-
Copy full SHA for 3a81d23 - Browse repository at this point
Copy the full SHA 3a81d23View commit details
Commits on Dec 6, 2023
-
Update src/bin/common/solving_loop.ml
Co-authored-by: Basile Clément <129742207+bclement-ocp@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8c9cc36 - Browse repository at this point
Copy the full SHA 8c9cc36View commit details -
Update src/lib/reasoners/intervalCalculus.ml
Co-authored-by: Basile Clément <129742207+bclement-ocp@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for eab3eb2 - Browse repository at this point
Copy the full SHA eab3eb2View commit details -
Update src/lib/reasoners/theory.ml
Co-authored-by: Basile Clément <129742207+bclement-ocp@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 568908f - Browse repository at this point
Copy the full SHA 568908fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9a81dd - Browse repository at this point
Copy the full SHA a9a81ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1109b0 - Browse repository at this point
Copy the full SHA d1109b0View commit details