Fix for bad ordering with $skiptoken
enabled and $orderby=... desc
#1054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We just encountered an issue related to the
EnableLowerCamelCase
feature, in a scenario where we issue a query with pagination enabled (using$skiptoken
) and a descending$orderby
.The issue is situated here :
AspNetCoreOData/src/Microsoft.AspNetCore.OData/Query/Query/DefaultSkipTokenHandler.cs
Line 315 in fce1c61
the keys in the dictionary do not match with the
key
variable because of the different casing. The same is happening with aliased properties.It results in a false 'false' evaluation of the
if
condition, and theelse
branch of the if is evaluated, generating a wrong predicate on SQL side (ascending instead of descending)The issue can be fixed here :
AspNetCoreOData/src/Microsoft.AspNetCore.OData/Query/Query/DefaultSkipTokenHandler.cs
Line 264 in fce1c61
by providing the proper keys to the
directionMap
dictionary.