-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AutoExpand Issues with Capitalized $Expand System Query Options #1292
Fix AutoExpand Issues with Capitalized $Expand System Query Options #1292
Conversation
…OData query parameters to prevent duplicates
…r better readability and maintability
test/Microsoft.AspNetCore.OData.E2E.Tests/AutoExpand/AutoExpandTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.AspNetCore.OData.E2E.Tests/AutoExpand/AutoExpandTests.cs
Outdated
Show resolved
Hide resolved
@WanjohiSammy does this issue only affect AutoExpand? Also do we have tests for query options without a $ prefix? |
…lIgnoreCase comparer instead of ToLowerInvariant()
@habbes This addresses the issue of Select or Expand AutoExpand navigation property using capitalized |
Issues
This pull request fixes #1284.
Description
When using AutoExpand, and specifying a system query option that's not lower case (such as $Expand) an exception is thrown. The exception indicates that Expand is being added twice.
This change is to resolve issues with the AutoExpand when using capitalized
$Expand
system query optionsFor example, given the following entities where
Friends
prop andTrip
class are AutoExpandWith this change, we should be able to use
$Expand
(capitalized of $expand) with the AutoExpand navigation properties:Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.