Validate ODL Version in csproj against builder.versions.settings.targets and update ODataLibPackageDependency to 8.2.3 #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanjohiSammy
changed the title
WanjohiSammy
changed the title
WanjohiSammy
requested review from
Copilot,
habbes,
marabooy and
xuzhg
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- tool/ValidateODataPackageVersions.ps1: Language not supported
- tool/builder.versions.settings.targets: Language not supported
xuzhg
previously approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- tool/ValidateODataPackageVersions.ps1: Language not supported
- tool/builder.versions.settings.targets: Language not supported
xuzhg
approved these changes
Jan 14, 2025
WanjohiSammy
deleted the
fix/1387-fix-incorrect-odatalib-dependency-version
branch
WanjohiSammy
added a commit
that referenced
this pull request
Jan 30, 2025
…ets and update ODataLibPackageDependency to 8.2.3 (#1389) * Add a step to pipeline to validate Validate OData Package Versions * Update ODataLibPackageDependency version to [8.2.3, 9.0.0) * Bump version to 9.1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #1387.
Description:
This change involves:
Microsoft.AspNetCore.OData.csprojagainst the version inbuilder.versions.settings.targets.This approach is to ensure that the OData Package version in the
Microsoft.AspNetCore.OData.csprojfile matches the version inbuilder.versions.settings.targetsas we consider the option of moving away hardcoded.nuspecfile:AspNetCoreOData/src/Microsoft.AspNetCore.OData.Release.nuspec
Lines 19 to 26 in df9c340