Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode segments. Fixes #1390 #1391

Closed
wants to merge 5 commits into from
Closed

Encode segments. Fixes #1390 #1391

wants to merge 5 commits into from

Conversation

uffelauesen
Copy link
Contributor

No description provided.

@WanjohiSammy
Copy link
Contributor

@uffelauesen
Kindly add some description and the issue that this PR is meant to resolve.

This change seems to resolve the issue: #1390

@WanjohiSammy
Copy link
Contributor

@uffelauesen
What is the different between this PR and PR #1383

@uffelauesen
Copy link
Contributor Author

Hi @WanjohiSammy
Yes - I can see that I have just pushed changes for both issue to the same branch (my main branch) instead of new branches for the issues they fixes. Thats why they look the same as they actually are pointing to the same branch.
I can redo that and create different branches for the 2 issues if you need that?
Thanks
Uffe

@uffelauesen
Copy link
Contributor Author

@WanjohiSammy I had a mess in my branch structure. I am going to close this one and create a new seperate PR for this - hopefully Monday.
Thanks

@uffelauesen
Copy link
Contributor Author

@WanjohiSammy
I have created a new PR for this. Please see #1396
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uffelauesen @WanjohiSammy