Make internal SelectExpandBinder methods public #840
Conversation
Can you point me to any EFCore example? Thanks. |
|
@xuzhg EntityFrameworkCore has a ServiceCollection where you can add stuff to with for example However, I think you don't take it far enough. Take a look at these EntityFrameworkCore classes/interfaces:
They allow extending because the necessary methods are public. Too many methods/classes are internal in OData which makes extending it without a custom copy of the code very difficult sometimes. |
KenitoInc
requested review from
KenitoInc,
xuzhg,
ElizabethOkerio,
gathogojr,
habbes and
lisicase
| @@ -44,7 +44,7 @@ public SelectExpandBinder(IFilterBinder filterBinder, IOrderByBinder orderByBind | |||
| /// <summary> | |||
| /// For unit test only. | |||
| /// </summary> | |||
| internal SelectExpandBinder() | |||
| public SelectExpandBinder() | |||
There was a problem hiding this comment.
We don't need to make this method public since it's only used internally with some tests.
| @@ -89,7 +89,7 @@ public virtual Expression BindSelectExpand(SelectExpandClause selectExpandClause | |||
| return projectionLambdaExpression; | |||
| } | |||
|
|
|||
| internal Expression ProjectAsWrapper(QueryBinderContext context, Expression source, SelectExpandClause selectExpandClause, | |||
| public Expression ProjectAsWrapper(QueryBinderContext context, Expression source, SelectExpandClause selectExpandClause, | |||
There was a problem hiding this comment.
Make method virtual and add docstrings.
| @@ -336,7 +336,7 @@ public class Child : Father | |||
|
|
|||
| // Generates the expression | |||
| // source => new Wrapper { Instance = source, Container = new PropertyContainer { ..expanded properties.. } } | |||
| internal Expression ProjectElement(QueryBinderContext context, Expression source, SelectExpandClause selectExpandClause, IEdmStructuredType structuredType, IEdmNavigationSource navigationSource) | |||
| public Expression ProjectElement(QueryBinderContext context, Expression source, SelectExpandClause selectExpandClause, IEdmStructuredType structuredType, IEdmNavigationSource navigationSource) | |||
There was a problem hiding this comment.
Make method virtual and add docstrings.
| @@ -476,7 +476,7 @@ internal Expression ProjectElement(QueryBinderContext context, Expression source | |||
| /// <param name="propertiesToExpand">The out properties to expand at current level, could be null.</param> | |||
| /// <param name="autoSelectedProperties">The out auto selected properties to include at current level, could be null.</param> | |||
| /// <returns>true if the select contains dynamic property selection, false if it's not.</returns> | |||
| internal static IList<DynamicPathSegment> GetSelectExpandProperties(IEdmModel model, IEdmStructuredType structuredType, IEdmNavigationSource navigationSource, | |||
| public static IList<DynamicPathSegment> GetSelectExpandProperties(IEdmModel model, IEdmStructuredType structuredType, IEdmNavigationSource navigationSource, | |||
There was a problem hiding this comment.
This method is static and cannot be overriden. How do you plan to use it?
| @@ -829,7 +829,7 @@ public virtual Expression CreateTotalCountExpression(QueryBinderContext context, | |||
| /// <param name="navigationProperty">The expanded navigation property.</param> | |||
| /// <param name="expandedItem">The expanded navigation select item. It may contain the nested query options.</param> | |||
| /// <param name="includedProperties">The container to hold the created property.</param> | |||
| internal void BuildExpandedProperty(QueryBinderContext context, Expression source, IEdmStructuredType structuredType, | |||
| public void BuildExpandedProperty(QueryBinderContext context, Expression source, IEdmStructuredType structuredType, | |||
| @@ -909,7 +909,7 @@ public virtual Expression CreateTotalCountExpression(QueryBinderContext context, | |||
| /// <param name="structuralProperty">The selected structural property.</param> | |||
| /// <param name="pathSelectItem">The selected item. It may contain the nested query options and could be null.</param> | |||
| /// <param name="includedProperties">The container to hold the created property.</param> | |||
| internal void BuildSelectedProperty(QueryBinderContext context, Expression source, IEdmStructuredType structuredType, | |||
| public void BuildSelectedProperty(QueryBinderContext context, Expression source, IEdmStructuredType structuredType, | |||
|
@bdebaere Did you get a chance to look at the feedback from @KenitoInc? |
Because so many methods are marked internal it really makes expanding OData behavior quite a hassle. I implore you to take a look at how extensible EntityFrameworkCore is for example and to reconsider all these internal methods everywhere.