fix deltaset serialization issues #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElizabethOkerio
force-pushed
the
fix/deltaset_serialization_issues
branch
4 times, most recently
from
1460bb1
to
9bacb76
Compare
gathogojr
reviewed
May 17, 2023
src/Microsoft.AspNetCore.OData/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNetCore.OData/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNetCore.OData/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.AspNetCore.OData.E2E.Tests/BulkOperation/BulkOperationDataModel.cs
Show resolved
Hide resolved
test/Microsoft.AspNetCore.OData.E2E.Tests/BulkOperation/BulkOperationController.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.AspNetCore.OData.E2E.Tests/BulkOperation/BulkOperationController.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.AspNetCore.OData.E2E.Tests/BulkOperation/BulkOperationController.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.AspNetCore.OData.E2E.Tests/BulkOperation/BulkOperationEdmModel.cs
Outdated
Show resolved
Hide resolved
ElizabethOkerio
force-pushed
the
fix/deltaset_serialization_issues
branch
from
e9ac262
to
053c029
Compare
ElizabethOkerio
force-pushed
the
fix/deltaset_serialization_issues
branch
from
053c029
to
eaaa69c
Compare
gathogojr
reviewed
May 22, 2023
gathogojr
reviewed
May 22, 2023
src/Microsoft.AspNetCore.OData/Formatter/Serialization/ODataResourceSerializer.cs
Show resolved
Hide resolved
gathogojr
reviewed
May 22, 2023
test/Microsoft.AspNetCore.OData.E2E.Tests/BulkOperation/BulkOperationEdmModel.cs
Show resolved
Hide resolved
gathogojr
reviewed
May 22, 2023
src/Microsoft.AspNetCore.OData/Formatter/Serialization/ODataResourceSerializer.cs
Show resolved
Hide resolved
gathogojr
approved these changes
May 22, 2023
habbes
reviewed
May 23, 2023
src/Microsoft.AspNetCore.OData/Formatter/Serialization/ODataResourceSerializer.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for serializing a DeltaSet in 8.X.. There are some erros that get thrown when serializing a DeltaSet.
Writing the nested resources in a DeltaSet was not supported. I have added logic to support that. I have added a method called
WriteDeltaNavigationPropertiesAsyncthat has logic for serializing nested resources in a DeltaSet.Another issue that was there is that we were not getting the EdmType correctly of a DeltaSet type. There was no logic for checking whether the type we are serializing is an
IDeltaor not. Have added those checks.