Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect case for PublicAPI folder #2406

Closed
dweeden opened this issue May 6, 2022 · 2 comments · Fixed by #2549
Closed

incorrect case for PublicAPI folder #2406

dweeden opened this issue May 6, 2022 · 2 comments · Fixed by #2549
Assignees

Comments

@dweeden
Copy link

dweeden commented May 6, 2022

The last three letters of the path odata.net/src/Microsoft.OData.Edm/PublicApi should be upper case so it compiles on Linux without generating a bunch of RS0016 errors

Assemblies affected

Current version of Microsoft.OData.Edm

Reproduce steps

Pull source onto a Linux machine and try to compile Microsoft.OData.Edm project

Expected result

It would compile

Actual result

It doesn't compile and yields a whole slew of RS0016 errors as it can't find the shipped and unshipped API files

Additional detail

@dweeden
Copy link
Author

dweeden commented May 6, 2022

Renaming it to PublicAPI fixes the problem for me locally

@AntiGuideAkquinet
Copy link
Contributor

AntiGuideAkquinet commented Sep 27, 2022

@corranrogue9
It seems to me like changing the Microsoft.OData.Edm.csproj like this

// DELETE
<AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Shipped.txt" />
<AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Unshipped.txt" />
// INSERT
<AdditionalFiles Include="PublicApi/$(TargetFramework)/PublicAPI.Shipped.txt" />
<AdditionalFiles Include="PublicApi/$(TargetFramework)/PublicAPI.Unshipped.txt" />

would solve the issue. Due to the dependency on VS2019 Enterprise in the build scripts I can't verify this tough.
This issue seems like it would have a lot of impact to users building in CI pipelines or on Linux host machines.

EDIT:
Renaming the directory was the right call. The above did not work in my tests.

AntiGuideAkquinet added a commit to AntiGuideAkquinet/odata.net that referenced this issue Oct 18, 2022
…#2406

Renaming the PublicApi directory to PublicAPI fixed compilation on Linux devices.
This influences CI/CD pipelines and developers on Linux machines in general.
habbes pushed a commit to habbes/odata.net that referenced this issue Nov 11, 2022
…#2406

Renaming the PublicApi directory to PublicAPI fixed compilation on Linux devices.
This influences CI/CD pipelines and developers on Linux machines in general.
habbes added a commit that referenced this issue Nov 14, 2022
…#2549)

Renaming the PublicApi directory to PublicAPI fixed compilation on Linux devices.
This influences CI/CD pipelines and developers on Linux machines in general.

Co-authored-by: Lukas Wiedemann <lukas.wiedemann@akquinet.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants