Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Nuget build 7.12.3 seems to be published as debug build #2510

Closed
henning-krause opened this issue Sep 23, 2022 · 2 comments · Fixed by #2526
Closed

Current Nuget build 7.12.3 seems to be published as debug build #2510

henning-krause opened this issue Sep 23, 2022 · 2 comments · Fixed by #2526
Assignees
Labels
infrastructure build environment, engineering system and other things for developer productivity. P1

Comments

@henning-krause
Copy link
Contributor

I created a benchmark program to test the speed of my ODATA service and got this output from benchmark.net (my program was compiled in "Release" mode):

Assembly odata which defines benchmarks references non-optimized Microsoft.OData.Client
        If you own this dependency, please, build it in RELEASE.
        If you don't, you can disable this policy by using 'config.WithOptions(ConfigOptions.DisableOptimizationsValidator)'.
Assembly odata which defines benchmarks references non-optimized Microsoft.OData.Edm
        If you own this dependency, please, build it in RELEASE.
        If you don't, you can disable this policy by using 'config.WithOptions(ConfigOptions.DisableOptimizationsValidator)'.
Assembly odata which defines benchmarks references non-optimized Microsoft.OData.Core
        If you own this dependency, please, build it in RELEASE.
        If you don't, you can disable this policy by using 'config.WithOptions(ConfigOptions.DisableOptimizationsValidator)'.

And when decompiling the DLLs I find this line in the decompiled code:

[assembly: AssemblyConfiguration("Debug")]

Indeed, compared to version 7.12.2, the performance dropped noticable.

Can it be that the latest release was compiled in "Debug" mode?

Assemblies affected

Microsoft.OData.Client
Microsoft.OData.Edm
Microsoft.OData.Core

Which assemblies and versions are known to be affected e.g. OData .Net lib 7.x

Reproduce steps

  • Create a program that uses odata and use version 7.12.3.
  • Measure the speed of the pogram
  • Downgrade to 7.12.2
  • Notice that the performance improves.

Expected result

  • No performance regression

Actual result

  • Performance drops significantly
@habbes
Copy link
Contributor

habbes commented Sep 27, 2022

@henning-krause thanks for reporting this. Let us investigate this and revert back.

@habbes habbes self-assigned this Sep 27, 2022
@habbes habbes added P1 infrastructure build environment, engineering system and other things for developer productivity. labels Sep 27, 2022
@habbes habbes mentioned this issue Oct 13, 2022
2 tasks
@habbes
Copy link
Contributor

habbes commented Oct 18, 2022

@henning-krause version 7.12.4 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure build environment, engineering system and other things for developer productivity. P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants