-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version 7.12.4 #2526
Update version 7.12.4 #2526
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Issues
*This pull request fixes #2510 *
Description
Updates the version to 7.12.4. Also fixes the build pipeline so that the debug and release builds are copied to different directories,
Nuget-Debug
andNuget-Release
respectively. This avoids the confusion or the builds overwriting each other.To verify that the write builds were stored in the right folder I ran a nighly pipeline and download the artifacts. The I unzipped the
.nupkg
and opened the the dlls inildasm
and followed the instructions post here to tell whether the build is JIT optimized or not:ildasm
(an easy way to find is to open the Developer Command Prompt for Visual Studio and enter theildasm
command)MANIFEST
DebuggableAttribute
in the manifest.Here's what it looked like for a sample dll in the
Nuget-Release
folder. You can see the 4th byte is00
Here's what it looked like for a sample dll in the
Nuget-Debug
folder. You can see the 4th byte is01
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.