Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-In Functions to be customized #378

Closed
YogiBear52 opened this issue Nov 15, 2015 · 2 comments
Closed

Built-In Functions to be customized #378

YogiBear52 opened this issue Nov 15, 2015 · 2 comments

Comments

@YogiBear52
Copy link

OData.Core has Built-In Functions like 'contains' 'endswith' 'geo.intersects' and so on. These functions are hard coded and cannot be customized or be modify.

OData lib has to be open and easy to be customized and modified by the users needs.

I suggest to add Custom Functions mechanism so the user could add,modify or override the existing pre defined built-in functions.
@congysu congysu added this to the 6.15 milestone Nov 17, 2015
@YogiBear52 YogiBear52 mentioned this issue Nov 23, 2015
Closed
YogiBear52 pushed a commit to YogiBear52/odata.net that referenced this issue Dec 22, 2015
Built-In Functions to be customized OData#378
46979f4 
* CustomUriFunctions - public API to add/remove or override builtIn functions.
* CustomUriFunctions and BuiltInFunctions tests
* Changed class name from 'BuiltInFunctions' to 'BuiltInUriFunctions'.
* The new class 'UriFunctionsHelper' contains general usage for both BuiltIn and Custom functions.
YogiBear52 pushed a commit to YogiBear52/odata.net that referenced this issue Jan 8, 2016
Fixes to LaylaLiu, Issue OData#378 OData#430
d4c4d8f 
- Usage of 'ExceptionUtils'
- Typo fixes
- lock 'TryGetCustomFunction' method
LaylaLiu pushed a commit to LaylaLiu/odata.net that referenced this issue Jan 13, 2016
@LaylaLiu
Built-In Functions to be customized OData#378
174da80 
* CustomUriFunctions - public API to add/remove or override builtIn functions.
* CustomUriFunctions and BuiltInFunctions tests
* Changed class name from 'BuiltInFunctions' to 'BuiltInUriFunctions'.
* The new class 'UriFunctionsHelper' contains general usage for both BuiltIn and Custom functions.
LaylaLiu pushed a commit to LaylaLiu/odata.net that referenced this issue Jan 13, 2016
@LaylaLiu
Fixes to LaylaLiu, Issue OData#378 OData#430
2d69557 
- Usage of 'ExceptionUtils'
- Typo fixes
- lock 'TryGetCustomFunction' method
LaylaLiu pushed a commit to LaylaLiu/odata.net that referenced this issue Jan 13, 2016
@LaylaLiu
Built-In Functions to be customized OData#378
c49a6df 
* CustomUriFunctions - public API to add/remove or override builtIn functions.
* CustomUriFunctions and BuiltInFunctions tests
* Changed class name from 'BuiltInFunctions' to 'BuiltInUriFunctions'.
* The new class 'UriFunctionsHelper' contains general usage for both BuiltIn and Custom functions.
* Changed name of some methods :
'MatchSignatureToBuiltInFunction' to 'MatchSignatureToUriFunction'.
'BindAsBuiltInFunction' to 'BindAsUriFunction'.
LaylaLiu pushed a commit to LaylaLiu/odata.net that referenced this issue Jan 13, 2016
@LaylaLiu
Built-In Functions to be customized OData#378
f78ae27 
* CustomUriFunctions - public API to add/remove or override builtIn functions.
* CustomUriFunctions and BuiltInFunctions tests
* Changed class name from 'BuiltInFunctions' to 'BuiltInUriFunctions'.
* The new class 'UriFunctionsHelper' contains general usage for both BuiltIn and Custom functions.
* Changed name of some methods :
'MatchSignatureToBuiltInFunction' to 'MatchSignatureToUriFunction'.
'BindAsBuiltInFunction' to 'BindAsUriFunction'.
LaylaLiu pushed a commit to LaylaLiu/odata.net that referenced this issue Jan 13, 2016
@LaylaLiu
Built-In Functions to be customized OData#378
e975bcd 
* CustomUriFunctions - public API to add/remove or override builtIn functions.
* CustomUriFunctions and BuiltInFunctions tests
* Changed class name from 'BuiltInFunctions' to 'BuiltInUriFunctions'.
* The new class 'UriFunctionsHelper' contains general usage for both BuiltIn and Custom functions.
* Changed name of some methods :
'MatchSignatureToBuiltInFunction' to 'MatchSignatureToUriFunction'.
'BindAsBuiltInFunction' to 'BindAsUriFunction'.
@YogiBear52 YogiBear52 mentioned this issue Jan 16, 2016
Closed
@LaylaLiu LaylaLiu modified the milestone: 6.15 Mar 18, 2016
@brjohnstmsft
Copy link
Contributor

@LaylaLiu @YogiBear52 Why aren't custom functions determined based on the EDM model? Having a global table of functions is unfortunate since in some OData services, there are multiple models in the same AppDomain and not all of them have the same set of custom functions. The global table breaks the isolation between EDM models.

@AlanWong-MS
Copy link
Contributor

Per comment in #430, this issue has been resolved. Closing issue, but please feel free to continue the discussion here for any questions.

@LaylaLiu LaylaLiu removed the docs label Jun 6, 2017
@xuzhg xuzhg mentioned this issue Aug 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brjohnstmsft @LaylaLiu @congysu @YogiBear52 @AlanWong-MS