-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating point type parameters parsing problem #63
Comments
@Ruslan: Would you like to contribute a fix for the issue? Thanks. |
Same problem. Any update? |
If CurrentCulture is russian (for example), then double.Parse("0.23") will fail and double.Parse("0,23") will success - used comma instead of dot. |
PR #374 has been merged. @maximpashuk Thanks for your contribution again! |
When I call odata function with a double parameter, I can see that ExpressionLexer.MakeBestGuessOnNoSuffixStr method is using current thread culture for several TryParse method calls when trying to parse the parameter from the url. I suppose that to be a bug because the numeric literal format is fixed in OData-ABNF, the double one for example. It seems that there is a need to call TryParse with invariant culture, insn’t it?
The text was updated successfully, but these errors were encountered: