Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

countdistinct and $count are returning Edm.Int64 which is not spec compliant #758

Open
athoscouto opened this issue Feb 9, 2017 · 0 comments
Open

countdistinct and $count are returning Edm.Int64 which is not spec compliant #758

athoscouto opened this issue Feb 9, 2017 · 0 comments
Labels
needs-porting

Comments

@athoscouto
Copy link
Contributor

As described in OData Extension for Data Aggregation Version 4.0 on 3.1.3.5 Standard Aggregation Method countdistinct:

The result property MUST have type Edm.Decimal with Scale="0" and sufficient Precision.

and on 3.1.5 Virtual Property $count:

The result property will have type Edm.Decimal with Scale="0" and sufficient Precision.

Right now we are using Int64 for countdistinct and PR #738 will use it for $count too.
athoscouto pushed a commit to athoscouto/odata.net that referenced this issue Feb 9, 2017
@shinlges
Removing compiler warnings, adding negative test case, removing redun…
e5a33a0 
…dant code and adding comments referencing issue OData#758.
@athoscouto athoscouto mentioned this issue Feb 9, 2017
Closed
2 tasks
robward-ms pushed a commit to robward-ms/odata.net that referenced this issue Feb 13, 2017
@shinlges @robward-ms
Removing compiler warnings, adding negative test case, removing redun…
729e322 
…dant code and adding comments referencing issue OData#758.
robward-ms pushed a commit to robward-ms/odata.net that referenced this issue Feb 14, 2017
@shinlges @robward-ms
Removing compiler warnings, adding negative test case, removing redun…
f0b92c5 
…dant code and adding comments referencing issue OData#758.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-porting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@athoscouto @manivannanse