Continue on [#1298] Support for OData $count operations as per v4.01 spec section 11.2.10 feature

[xuzhg]

Issues

This pull request continues on PR #1298.

Description

• Fully update the PR Support for OData $count operations as per v4.01 spec section 11.2.10 #1298
• Modify to pass the build

Checklist (Uncheck if it is not completed)

• Test cases added
• Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

[KanishManuja-MS]

Unit tests failing.

[xuzhg]

@KanishManuja-MS Thanks. This PR is not labeled "Ready for review". Please ignore it now and I will update it later.

[joshcomley]

Other than the conflict, what is necessary to get this PR moving?

[KenitoInc]

Other than the conflict, what is necessary to get this PR moving?

Hey @joshcomley
Thanks for you contributions so far in relation to support for $count
Actually I have started looking into this feature. Specifically on these 2 requests:
$expand=navProp/$count
$select=navProp/$count
We need first to get the design.

ps: OData core is currently supporting
$filter=navProp/$count gt 10
$filter=collectionValuedProp/$count gt 10

odata.net/test/FunctionalTests/Microsoft.OData.Core.Tests/ScenarioTests/UriParser/FilterAndOrderByFunctionalTests.cs

Line 374 in 8522ce4

public void ParseFilterWithComplexCollectionCount()

Lets work together to ensure this feature is realised.
Thanks

[joshcomley]

Hi @KenitoInc - thanks for getting back so quick!

In case it is of any use, I have just updated my original PR rebasing onto master, merging with this PR's additions:

#1298

The tests pass except for one which I think is unrelated to this PR (Microsoft.OData.Tests.ScenarioTests.UriParser.CustomUriFunctionsTests.AddCustomFunction_ShouldAddFunctionWhichAlreadyExistsAsBuiltInWithSameName_AddAsOverload).

PR 1298 supports $expand=navProp/$count but it doesn't support $select=navProp/$count.

[KenitoInc]

Resolved by PRs #2051 and #2069