-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nextPageLink/Count in ODataCollectionStart and write them to response in ODataJsonLightCollectionSerializer.cs #166
Conversation
Added support to ClientEdmModel to consult IEdmEntityType's IsOpen property when instantiating EdmEntityTypeWithDelayLoadedProperties and EdmComplexTypeWithDelayLoadedProperties. ClientEdmModel was always setting isOpen to false for these instances. This fixes an issue where sending arbitrary/undeclared ODataProperty instances up would throw in WriterValidationUtil.ValidatePropertyDefined(). This addresses OData#143
… written into response.
This reverts commit fefc1a7.
Hi @Chinese007, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@Chinese007, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
@@ -50,6 +50,20 @@ internal void WriteCollectionStart(ODataCollectionStart collectionStart, IEdmTyp | |||
// "@odata.context":... | |||
this.WriteContextUriProperty(ODataPayloadKind.Collection, () => ODataContextUrlInfo.Create(collectionStart.SerializationInfo, itemTypeReference)); | |||
|
|||
// "@odata.count":... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chinese007 Add some test cases. Also need to change the WriteCollectionEnd
. De-serialize nextlink and count. Optional, depend on your user scenario, handle inline scenario
Commits from @Chinese007 : 5b03cc4 and ddc5eea |
@lewischeng-ms Thanks very much for the fix. Do we know which build will contain this fix? Thanks! |
Hi @Chinese007 , if you want the binaries immediately, please use our nightly builds (https://github.com/OData/odata.net#nightly-builds). Otherwise, please wait for the next release (v6.13). |
The change list here is the first step to fix issue(#140):
Another pull request will be made against WebAPI OData repository to have the issue fully addressed.