Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextPageLink/Count in ODataCollectionStart and write them to response in ODataJsonLightCollectionSerializer.cs #166

Closed
wants to merge 5 commits into from

Conversation

James-Bao
Copy link
Contributor

The change list here is the first step to fix issue(#140):

  1. New properties have been introduced in ODataCollectionStart
  2. If nextPageLink/Count is specified, the ODataJsonLightCollectionSerializer will write them into the response.

Another pull request will be made against WebAPI OData repository to have the issue fully addressed.

AdamCaviness and others added 4 commits April 22, 2015 09:44
Added support to ClientEdmModel to consult IEdmEntityType's IsOpen
property when instantiating EdmEntityTypeWithDelayLoadedProperties and
EdmComplexTypeWithDelayLoadedProperties.  ClientEdmModel was always
setting isOpen to false for these instances. This fixes an issue where
sending arbitrary/undeclared ODataProperty instances up would throw in
WriterValidationUtil.ValidatePropertyDefined().  This addresses
OData#143
@msftclas
Copy link

Hi @Chinese007, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@Chinese007, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@@ -50,6 +50,20 @@ internal void WriteCollectionStart(ODataCollectionStart collectionStart, IEdmTyp
// "@odata.context":...
this.WriteContextUriProperty(ODataPayloadKind.Collection, () => ODataContextUrlInfo.Create(collectionStart.SerializationInfo, itemTypeReference));

// "@odata.count":...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chinese007 Add some test cases. Also need to change the WriteCollectionEnd. De-serialize nextlink and count. Optional, depend on your user scenario, handle inline scenario

@lewischeng-ms
Copy link
Contributor

Commits from @Chinese007 : 5b03cc4 and ddc5eea

@lewischeng-ms
Copy link
Contributor

Final commits: b3a8af8, f268279 and 7a60423

@James-Bao
Copy link
Contributor Author

@lewischeng-ms Thanks very much for the fix. Do we know which build will contain this fix? Thanks!

@lewischeng-ms
Copy link
Contributor

Hi @Chinese007 , if you want the binaries immediately, please use our nightly builds (https://github.com/OData/odata.net#nightly-builds). Otherwise, please wait for the next release (v6.13).

@congysu congysu added this to the 6.13 milestone Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants