-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CreateAsynchronousJsonWriter to IStreamBasedJsonWriterFactoryAsync #2461
Add CreateAsynchronousJsonWriter to IStreamBasedJsonWriterFactoryAsync #2461
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issues
Related to #2421
Description
This PR adds the
CreateAsynchronousJsonWriter
method to theIStreamBasedJsonWriter
interface that was introduced as part of theODataUtf8JsonWriter
work (#2416).This method will allow the same interface to also be used to create
IJsonWriterAsync
. This is a change that is being back-ported from the currently pending PR that's implementing the async API forODataUtf8JsonWriter
(#2460).The goal is to merge this PR before the next release so that when we release the async API for
ODataUtf8JsonWriter
, it will not be a breaking change.Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.