add bulkupdateasync #2655
Merged
add bulkupdateasync #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElizabethOkerio
force-pushed
the
feature/support_bulkupdate_async_apis
branch
from
6d21e4d to
e7c6769
Compare
habbes
reviewed
Apr 25, 2023
test/FunctionalTests/Tests/DataServices/UnitTests/Client.TDD.Tests/Tests/BulkUpdateE2ETests.cs
Show resolved
Hide resolved
ElizabethOkerio
force-pushed
the
feature/support_bulkupdate_async_apis
branch
from
03ea6f1 to
52487c2
Compare
habbes
reviewed
Apr 27, 2023
test/FunctionalTests/Tests/DataServices/UnitTests/Client.TDD.Tests/Tests/BulkUpdateE2ETests.cs
Outdated
Show resolved
Hide resolved
| } | ||
| finally | ||
| { | ||
| this.HandleCompleted(pereq); |
There was a problem hiding this comment.
Where is it getting disposed?
I see that we're disposing perReq at some point, but looking at the source code of PerRequest.Dispose(), it doesn't seem to be disposing it's PerRequest.Request object. So it's still not clear to me at what point we're disposing this.bulkUpdateRequestMessage.
xuzhg
previously approved these changes
Apr 27, 2023
test/FunctionalTests/Tests/DataServices/UnitTests/Client.TDD.Tests/Tests/BulkUpdateE2ETests.cs
Show resolved
Hide resolved
ElizabethOkerio
force-pushed
the
feature/support_bulkupdate_async_apis
branch
from
77a1b0e to
8b9b30a
Compare
ElizabethOkerio
force-pushed
the
feature/support_bulkupdate_async_apis
branch
from
c8ddc6f to
7725fb9
Compare
habbes
reviewed
Apr 28, 2023
test/FunctionalTests/Tests/DataServices/UnitTests/Client.TDD.Tests/Tests/BulkUpdateE2ETests.cs
Outdated
Show resolved
Hide resolved
| } | ||
| finally | ||
| { | ||
| this.HandleCompleted(pereq); |
There was a problem hiding this comment.
I see. It's strange that it doesn't implement IDisposable, seems like design flaw. I wonder whether we may have any resource leaks since at least the underlying HttpClientRequestMessage is disposable.
habbes
previously approved these changes
Apr 28, 2023
ElizabethOkerio
force-pushed
the
feature/support_bulkupdate_async_apis
branch
from
4ae957b to
c0741e4
Compare
KenitoInc
approved these changes
Apr 28, 2023
habbes
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This PR adds the
BulkUpdateAsyncmethod. This method allows users to carry out bulk update requests asynchronously.The PR uses the
FromAsyncpattern that is currently supported in OData Client to wrap theBeginBulkUpdateandEndBulkUpdatemethods of aBulkUpdateoperation.To the DataServiceContext, I have added the
BulkUpdateAsync,BeginBulkUpdateandEndBulkUpdatemethods. Within theBulkUpdateAsyncmethod I'm using theFromAsyncmethod to wrap theBeginBulkUpdateandEndBulkUpdatemethods.Description
Briefly describe the changes of this pull request.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.