Fix async wrapper over sync API in reading nested property info #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gathogojr
requested review from
marabooy,
wandeg,
wachugamaina,
KenitoInc,
habbes,
xuzhg,
WanjohiSammy and
ElizabethOkerio
habbes
approved these changes
Jun 7, 2024
ElizabethOkerio
approved these changes
Jun 10, 2024
gathogojr
deleted the
fix/async-wrapper-over-sync-in-reading-nested-property-info
branch
gathogojr
added a commit
to gathogojr/odata.net
that referenced
this pull request
Jun 10, 2024
gathogojr
added a commit
to gathogojr/odata.net
that referenced
this pull request
Jun 10, 2024
gathogojr
added a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix async wrapper over sync API in reading nested property info - prevent inadvertent sync IO
This is why/how the sync method was being called:
odata.net/src/Microsoft.OData.Core/ODataReaderCoreAsync.cs
Lines 88 to 91 in 383e29f
The async methods are declared in the
ODataReaderCoreAsyncbase class and their default implementation is to wrap the sync method.If they're not overridden in the derived class, they'll do sync IO. The
ReadAtNestedPropertyInfoImplementationAsyncwas inadvertently not overridden inODataJsonLightReaderclass.Checklist (Uncheck if it is not completed)