Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Error occurs when you check whether a string or integer literal is in an enum collection #3023

Merged
merged 14 commits into from
Aug 16, 2024
Merged

Fix for Error occurs when you check whether a string or integer literal is in an enum collection #3023

merged 14 commits into from
Aug 16, 2024

Commits on Jul 22, 2024

  1. Refactor InBinder to convert left operand to enum type if necessary

    @WanjohiSammy
    WanjohiSammy committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    a101461 View commit details
    Browse the repository at this point in the history

  2. Add tests for filter with In Operator with enums member names and mem… 

    …ber integral values
    @WanjohiSammy
    WanjohiSammy committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    cdc0cb1 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Add more functional tests for parseFilter with 'In' Operation with Enums

    @WanjohiSammy
    WanjohiSammy committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2eb3a56 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Add a failed tests when Float are used as enum integral value with In… 

    … Operator
    @WanjohiSammy
    WanjohiSammy committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1ad2413 View commit details
    Browse the repository at this point in the history

  2. Add parse filter test with 'In' operator with enums where left operan… 

    …d is Invalid integral values
    @WanjohiSammy
    WanjohiSammy committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8f35954 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Adding tests for errors thrown when using string literal that doesn't… 

    … exists as enum member name
    @WanjohiSammy
    WanjohiSammy committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2f7bda7 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Refactor to reuse methods and move logic that check if convert left n… 

    …ode is required to private method
    @WanjohiSammy
    WanjohiSammy committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a2d1935 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Remove unnecessary ShouldConvertLeftOperand() method and put the logi… 

    …c inside BindInOperator()
    @WanjohiSammy
    WanjohiSammy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    299516f View commit details
    Browse the repository at this point in the history

  2. Make the new tests to only use generic methods introduced

    @WanjohiSammy
    WanjohiSammy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5f65354 View commit details
    Browse the repository at this point in the history

  3. Resolve comments

    @WanjohiSammy
    WanjohiSammy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    b524e5b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fix/2371-allow-filter-stringliterals-in-enum-collection… 

    …' of https://github.com/OData/odata.net into fix/2371-allow-filter-stringliterals-in-enum-collection
    @WanjohiSammy
    WanjohiSammy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f0fbbde View commit details
    Browse the repository at this point in the history

  5. Reuse GetIEdmProperty() and GetIEdmType() methods in the other existi… 

    …ng tests
    @WanjohiSammy
    WanjohiSammy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    8f0698b View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge related tests using [Theory]

    @WanjohiSammy
    WanjohiSammy committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    07655ee View commit details
    Browse the repository at this point in the history

  2. use string instead of object

    @WanjohiSammy
    WanjohiSammy committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    3f4f00a View commit details
    Browse the repository at this point in the history