Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 8.0.0 #3033

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Update version to 8.0.0 #3033

merged 2 commits into from
Aug 12, 2024

Conversation

habbes
Copy link
Contributor

@habbes habbes commented Aug 12, 2024

Updates version to 8.0.0 (official release). Also moves public API to shipped.

@ElizabethOkerio
Copy link
Contributor

ElizabethOkerio commented Aug 12, 2024

cxcx

I think we need to get rid of this. Or this is ok? We should only have .net 8.0 as the dependencies.
Remove from here:
https://github.com/OData/odata.net/blob/dev-8.x/src/Microsoft.OData.Core/Build.NuGet/Microsoft.OData.Core.Release.nuspec#L23

@gathogojr
Copy link
Contributor

What are the next steps after merging this pull request to dev-8.x? Will we continue to do 8.x releases from that branch and 7.x releases from the main branch?

@gathogojr
Copy link
Contributor

For the empty */PublicAPI/net48/PublicAPI.Shipped.txt files, I think you should have deleted them altogether after deleting the equivalent */PublicAPI/net48/PublicAPI.Unshipped.txt files

@gathogojr
Copy link
Contributor

Maybe double-check that src/Microsoft.OData.Core/Build.NuGet/Microsoft.OData.Core.Nightly.Release.nuspec and src/Microsoft.OData.Core/Build.NuGet/Microsoft.OData.Core.Nightly.Release.nuspec are updated with all referenced dependencies...

@habbes
Copy link
Contributor Author

habbes commented Aug 12, 2024

For the empty */PublicAPI/net48/PublicAPI.Shipped.txt files, I think you should have deleted them altogether after deleting the equivalent */PublicAPI/net48/PublicAPI.Unshipped.txt files

I deleted them already. Not sure why they're showing up in the diff as "empty". Maybe it's because the files were already empty. But I deleted the actual folders.

@gathogojr
Copy link
Contributor

For the empty */PublicAPI/net48/PublicAPI.Shipped.txt files, I think you should have deleted them altogether after deleting the equivalent */PublicAPI/net48/PublicAPI.Unshipped.txt files

I deleted them already. Not sure why they're showing up in the diff as "empty". Maybe it's because the files were already empty. But I deleted the actual folders.

Okay. Maybe just check to ensure that the logic that generates them isn't causing them to be regenerated as empty files

@habbes
Copy link
Contributor Author

habbes commented Aug 12, 2024

For the empty */PublicAPI/net48/PublicAPI.Shipped.txt files, I think you should have deleted them altogether after deleting the equivalent */PublicAPI/net48/PublicAPI.Unshipped.txt files

I deleted them already. Not sure why they're showing up in the diff as "empty". Maybe it's because the files were already empty. But I deleted the actual folders.

Okay. Maybe just check to ensure that the logic that generates them isn't causing them to be regenerated as empty files

Since it's no longer a target framework, they don't get regenerated. Those were leftover files from before we removed .net48 as a target.

@habbes
Copy link
Contributor Author

habbes commented Aug 12, 2024

What are the next steps after merging this pull request to dev-8.x? Will we continue to do 8.x releases from that branch and 7.x releases from the main branch?

We'll create a new branch for 7.x from and make main point to what is now dev-8.x

@habbes
Copy link
Contributor Author

habbes commented Aug 12, 2024

cxcx I think we need to get rid of this. Or this is ok? We should only have .net 8.0 as the dependencies. Remove from here: https://github.com/OData/odata.net/blob/dev-8.x/src/Microsoft.OData.Core/Build.NuGet/Microsoft.OData.Core.Release.nuspec#L23

I've removed the nestandard 2.0 references and moved the dependencies it had to the first <dependencies> block

@habbes habbes merged commit 8ca731e into OData:dev-8.x Aug 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants