Cherry-pick (7d5c6c5): Fix for Error occurs when you check whether a string or integer literal is in an enum collection #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al is in an enum collection (#3023) * Refactor InBinder to convert left operand to enum type if necessary * Add tests for filter with In Operator with enums member names and member integral values * Add more functional tests for parseFilter with 'In' Operation with Enums * Add a failed tests when Float are used as enum integral value with In Operator * Add parse filter test with 'In' operator with enums where left operand is Invalid integral values * Adding tests for errors thrown when using string literal that doesn't exists as enum member name * Refactor to reuse methods and move logic that check if convert left node is required to private method * Remove unnecessary ShouldConvertLeftOperand() method and put the logic inside BindInOperator() * Make the new tests to only use generic methods introduced * Resolve comments * Reuse GetIEdmProperty() and GetIEdmType() methods in the other existing tests * Merge related tests using [Theory] * use string instead of object
WanjohiSammy
changed the title
habbes
approved these changes
Aug 16, 2024
gathogojr
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick 7d5c6c5
Checklist (Uncheck if it is not completed)