-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port ContainmentTests #3046
Merged
Merged
Port ContainmentTests #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElizabethOkerio
requested review from
marabooy,
paulodero,
KenitoInc,
habbes,
xuzhg,
WanjohiSammy and
gathogojr
August 26, 2024 04:20
ElizabethOkerio
force-pushed
the
port_containment_tests
branch
from
August 26, 2024 04:22
33f6803
to
9c18b65
Compare
marabooy
previously approved these changes
Aug 26, 2024
marabooy
reviewed
Aug 26, 2024
...sts/Tests/Client/Microsoft.OData.Client.E2E.Tests/Common/Server/Default/DefaultDataSource.cs
Outdated
Show resolved
Hide resolved
gathogojr
reviewed
Aug 27, 2024
...dTests/Common/Microsoft.OData.Client.E2E.TestCommon/Common/CustomHttpClientRequestMessage.cs
Outdated
Show resolved
Hide resolved
gathogojr
reviewed
Aug 27, 2024
...ests/Tests/Client/Microsoft.OData.Client.E2E.Tests/Common/Server/Default/DefaultDataModel.cs
Show resolved
Hide resolved
ElizabethOkerio
force-pushed
the
port_containment_tests
branch
from
August 27, 2024 07:14
075738f
to
9c859c4
Compare
ElizabethOkerio
force-pushed
the
port_containment_tests
branch
from
August 27, 2024 07:55
e4ef294
to
7692edc
Compare
nit: If |
gathogojr
reviewed
Aug 27, 2024
.../Client/Microsoft.OData.Client.E2E.Tests/ContainmentTest/Server/ContainmentTestController.cs
Outdated
Show resolved
Hide resolved
gathogojr
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #xxx.
Description
This PR ports E2E client tests from depending on WCF services to use Microsoft.AspNetCore.OData. Here is a link to the tests that need porting: https://github.com/OData/odata.net/blob/release-7.x/test/EndToEndTests/Tests/Client/Build.Desktop/ContainmentTest/ContainmentTest.cs
These tests test Containment ODataNet.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.