Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ContainmentTests #3046

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Port ContainmentTests #3046

merged 2 commits into from
Aug 27, 2024

Conversation

ElizabethOkerio
Copy link
Contributor

@ElizabethOkerio ElizabethOkerio commented Aug 26, 2024

Issues

This pull request fixes #xxx.

Description

This PR ports E2E client tests from depending on WCF services to use Microsoft.AspNetCore.OData. Here is a link to the tests that need porting: https://github.com/OData/odata.net/blob/release-7.x/test/EndToEndTests/Tests/Client/Build.Desktop/ContainmentTest/ContainmentTest.cs

These tests test Containment ODataNet.

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

marabooy
marabooy previously approved these changes Aug 26, 2024
@gathogojr
Copy link
Contributor

nit: If ContainmentTest and ContainmentTestController files are new files you introduced, perhaps you should align the naming with how you have been doing it in other pull requests, i.e., ContainmentTest => ContainmentTests and ContainmentTestController => ContainmentTestsController

@ElizabethOkerio ElizabethOkerio merged commit 6ae19c9 into main Aug 27, 2024
5 checks passed
@ElizabethOkerio ElizabethOkerio deleted the port_containment_tests branch August 27, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants