Fix code coverage analysis #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
previously approved these changes
Sep 19, 2024
| @@ -37,6 +37,10 @@ | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.0" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp1.1' or '$(TargetFramework)' == 'net452'"> | |||
There was a problem hiding this comment.
why do we still support 'netcoreapp1.1'?
There was a problem hiding this comment.
Seems that this PR is targeted at 7.x branch.
| @@ -28,7 +28,7 @@ | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.0" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp1.1'"> | |||
| <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp1.1' or '$(TargetFramework)' == 'net452'"> | |||
There was a problem hiding this comment.
This pull request is targeted at 7.x
habbes
previously approved these changes
Sep 23, 2024
gathogojr
force-pushed
the
fix/code-coverage-analysis
branch
from
2da5746 to
20767ad
Compare
gathogojr
force-pushed
the
fix/code-coverage-analysis
branch
from
20767ad to
ad2cb08
Compare
gathogojr
requested review from
marabooy,
habbes,
xuzhg,
WanjohiSammy and
DButoyez
marabooy
previously approved these changes
Sep 26, 2024
habbes
previously approved these changes
Sep 26, 2024
Co-authored-by: David W <1511024+marabooy@users.noreply.github.com>
marabooy
approved these changes
Oct 1, 2024
habbes
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix code coverage analysis
Restrict code coverage analysis to only the ODL libraries:
Checklist (Uncheck if it is not completed)