Do not force flush when ODataUtf8JsonWriter buffer threshold is reached #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habbes
requested review from
marabooy,
xuzhg,
WanjohiSammy,
corranrogue9 and
gathogojr
marabooy
approved these changes
Oct 30, 2024
WanjohiSammy
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #3099 .
This PR is an 8.x port of the following 7.x PR: #3101
Description
This PR removes the "Flush()" call from the
FlushIfBufferThresholdReachedmethod and renames the method toDrainBufferIfThresholdReached. This method no longer forces a flush of the underlying stream, instead it only writes to the stream but leaves the stream to decide whether/when to flush. The user can still force a flush by explicitly calling theFlush()method.Checklist (Uncheck if it is not completed)