Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OData error with target and details #76 #364

Closed
wants to merge 4 commits into from
Closed

Conversation

congysu
Copy link
Contributor

@congysu congysu commented Oct 29, 2015

Add target and details to OData error payload.
Add writer and reader tests.
Update public API baseline.

@congysu congysu added this to the 6.14 milestone Nov 10, 2015
@congysu congysu force-pushed the unseal branch 4 times, most recently from 99bbc05 to e41e22f Compare November 16, 2015 14:35
@congysu congysu changed the title Unseal ODataError class #76 OData error with target and details #76 Nov 16, 2015
Add writer and reader tests.
Update public API baseline.
@congysu
Copy link
Contributor Author

congysu commented Nov 17, 2015

@OData/odata-team Please help to review this PR. Thanks.

public string Target { get; set; }

/// <summary>
/// An array of JSON objects that MUST contain name/value pairs for code and message, and MAY contain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A collection of JSON objects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@lewischeng-ms
Copy link
Contributor

Looks good to me.

@congysu
Copy link
Contributor Author

congysu commented Nov 19, 2015

Checked-in 103b6a4 - 20151c2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants