Provide a better exception when a PrimitiveValue is encountered when … #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trying to read a ComplexType Currently, when we parse the JSON for a ComplexType property, if we encounter a PrimitiveValue, we get back an exception that is mostly useless to a client: An unexpected 'PrimitiveValue' node was found when reading from the JSON reader. A 'StartObject' node was expected. This change makes the exception provide the property name and a description of what was expected, including the type name.
|
submit with 942180d and closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…trying to read a ComplexType
Currently, when we parse the JSON for a ComplexType property, if we
encounter a PrimitiveValue, we get back an exception that is mostly
useless to a client:
An unexpected 'PrimitiveValue' node was found when reading from the JSON
reader. A 'StartObject' node was expected.
This change makes the exception provide the property name and a
description of what was expected, including the type name.
Resolves #487
Fix #487