properly close connection pool and shutdown transport #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before, running As discussed in the cpython issue, I think the proper behavior is to close the TCP transport in any way when it is not used anymore. Now, the tests for python 3.12 succeed as well, so I added this to the test suite. |
|
There was another deadlock which did shut down multiple containers correctly, as they have open connections to each other. Take a look here to see the successful actions run: |
This is needed for wait_closed to terminate starting from 3.12 Before, wait_closed was a noop and did not check for all clients to be closed. see python/cpython#104344
maurerle
force-pushed
the
fix_connection_pool_closing
branch
from
cee456a
to
64a9b14
Compare
…rialized with awaits This is needed as wait_closed now properly waits for all connections to be closed
maurerle
force-pushed
the
fix_connection_pool_closing
branch
from
64a9b14
to
60c826a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for wait_closed to terminate starting from 3.12 Before, wait_closed was a noop and did not check for all clients to be closed.
see python/cpython#104344
fixes #89