-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OHIF V3 with Orthanc MPR works fine on localhost but SharedArrayBuffer error over internet #3220
Comments
Anyone? |
please? |
have you tried putting the headers inside single quotes ? like this ?
|
is https required or will this work with simple hppt over the internet ? |
it should work with http |
Dear Ranasrule, |
we tried with with add header but it is not giving result. kindly advise on it to make it work |
@jbocce Do you know what is going on here? I believe it is the secure context problem. |
At first glance, I would say that the problem is that a secure context has not been established. So to answer a previous question from @ranasrule, https IS required over the internet. |
Secure context is required not just over the Internet but also over local
network. It's only not required on localhost.
…On Fri, 29 Sept 2023, 6:25 pm Joe Boccanfuso, ***@***.***> wrote:
@jbocce <https://github.com/jbocce> Do you know what is going on here? I
believe it is the secure context problem.
At first glance, I would say that the problem is that a secure context
<https://docs.ohif.org/deployment/cors#secure-context> has not been
established. So to answer a previous question from @ranasrule
<https://github.com/ranasrule>, https IS required over the internet.
—
Reply to this email directly, view it on GitHub
<#3220 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGKNOZ4C3UAX23VRMAULLDX43D5PANCNFSM6AAAAAAVRKV7QA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
localhost is secure by design https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts#when_is_a_context_considered_secure |
This really is a terrible decision by the developers as most pacs are used
primarily over the local network via their IP addresses hence a secure
context it not always possible.
…On Fri, 29 Sept 2023, 6:56 pm Alireza, ***@***.***> wrote:
localhost is secure by design
https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts#when_is_a_context_considered_secure
—
Reply to this email directly, view it on GitHub
<#3220 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGKNO633W5BZPWR6RQZB2DX43HR5ANCNFSM6AAAAAAVRKV7QA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
You can still use the StackViewport, however, if you want Volume rendering, you should be in a secure context. Just want to point out the decision of ONLY allowing SharedArrayBuffer to run in a secure context is by World Wide Web Consortium group and not OHIF |
But the decision to USE shared buffers was made by the OHIF team. Check out
the VolView plugin for Orthanc by Kitware. It manages to provide MPR and 3d
reconstruction in the browser without the need for any kind of secure
context.
…On Fri, 29 Sept 2023, 8:24 pm Alireza, ***@***.***> wrote:
You can still use the StackViewport, however, if you want Volume
rendering, you should be in a secure context. Just want to point out the
decision of enabling SharedArrayBuffer in a secure context is by World Wide
Web Consortium group and not OHIF
—
Reply to this email directly, view it on GitHub
<#3220 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGKNOYTNBS4HJKULQXDO5LX43RZXANCNFSM6AAAAAAVRKV7QA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
You can turn it off but it would be slower, just FYI (maybe I should have mentioned it in the previous reply)
ps: where is the link to your plugin for volview? |
Please see link below
https://book.orthanc-server.com/plugins/volview.html
…On Fri, Sep 29, 2023 at 9:20 PM Alireza ***@***.***> wrote:
You can turn it off but it would be slower, just FYI (maybe I should have
mentioned it in the previous reply)
useSharedArrayBuffer here
https://docs.ohif.org/configuration/configurationFiles
ps: where is the link to your plugin for volview?
—
Reply to this email directly, view it on GitHub
<#3220 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGKNOYAJBTWGM7RXUGV5VLX43YM3ANCNFSM6AAAAAAVRKV7QA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Regards,
Rana Asim Wajid
|
setting useSharedArrayBuffer to false gives the following error even when loading the study in non mpr mode |
Check this PR out, it will fix that bug after merge |
There is a very good chance you are saying false (boolean) while it should be string. I have another PR to fix this to support boolean too https://github.com/OHIF/Viewers/pull/3688/files If you see the memory snapshot there is not sharedArrayBuffer |
@sedghi I have set useSharedArrayBuffer: "FALSE" as you suggest but with the same results as you can see in the screenshots below One more thing...I have no idea if this has anything to do with the issue under discussion but Im also getting the error in the screenshot below in the browser console: |
You are putting it in a wrong location, it should be the root of the configuration |
Perfect...working great now. Thank you for all your contributions to this great project. |
Dears, I have two questions (additional details here):
Thanks and regards |
@mrceresa see our docs https://docs.ohif.org/deployment/ |
I have been pulling my hair out over the last three days trying to figure this out without any luck.....
Describe the Bug
OHIF V3 with Orthanc MPR functionality works fine on localhost but Error: Uncaught (in promise) Error: SharedArrayBuffer is NOT supported in your browser see https://developer.chrome.com/blog/enabling-shared-array-buffer/ error occurs when accessing over that internet
Steps to Reproduce:
my nginx config file is below:
My app-config.js is below
The current behavior
OHIF V3 with Orthanc MPR functionality works fine on localhost but Error: Uncaught (in promise) Error: SharedArrayBuffer is NOT supported in your browser see https://developer.chrome.com/blog/enabling-shared-array-buffer/ error occurs when accessing over that internet
The expected behavior
It should work over the internet as well as localhost
I tried using the example nginx config file here as a guide >>> https://github.com/OHIF/Viewers/blob/master/.docker/Nginx-Orthanc/config/nginx.conf but no luck.
The text was updated successfully, but these errors were encountered: