OHIF V3 with Orthanc MPR works fine on localhost but SharedArrayBuffer error over internet #3220

ranasrule · 2023-03-06T16:19:46Z

I have been pulling my hair out over the last three days trying to figure this out without any luck.....

Describe the Bug

OHIF V3 with Orthanc MPR functionality works fine on localhost but Error: Uncaught (in promise) Error: SharedArrayBuffer is NOT supported in your browser see https://developer.chrome.com/blog/enabling-shared-array-buffer/ error occurs when accessing over that internet

Steps to Reproduce:

open any study on localhost and switch to MPR view. It will work find
open any study over the internet and switch to MPR view. It will generate Error: Uncaught (in promise) Error: SharedArrayBuffer is NOT supported in your browser see https://developer.chrome.com/blog/enabling-shared-array-buffer/ error in browser console and MPR will not generate.

my nginx config file is below:

worker_processes 1;

events { worker_connections 1024; }

http {

    upstream orthanc-server {
        server 127.0.0.1:8099;
    }

    server {
        listen [::]:8099 default_server;
        listen 8099;

        # CORS Magic
        add_header 'Access-Control-Allow-Origin' '*';
        add_header 'Access-Control-Allow_Credentials' 'true';
        add_header 'Access-Control-Allow-Headers' 'Authorization,Accept,Origin,DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Content-Range,Range';
        add_header 'Access-Control-Allow-Methods' 'GET,POST,OPTIONS,PUT,DELETE,PATCH';

        location / {
		
			if ($request_method = 'OPTIONS') {
                add_header 'Access-Control-Allow-Origin' '*';
                add_header 'Access-Control-Allow_Credentials' 'true';
                add_header 'Access-Control-Allow-Headers' 'Authorization,Accept,Origin,DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Content-Range,Range';
                add_header 'Access-Control-Allow-Methods' 'GET,POST,OPTIONS,PUT,DELETE,PATCH';
                add_header 'Access-Control-Max-Age' 1728000;
                add_header 'Content-Type' 'text/plain charset=UTF-8';
                add_header 'Content-Length' 0;
                return 204;
            }
			try_files $uri $uri/ /index.html;
			add_header 'Access-Control-Allow-Credentials' 'true';
            add_header 'Access-Control-Allow-Headers' 'DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type';
            add_header 'Access-Control-Allow-Methods' 'GET, POST, OPTIONS';
            add_header 'Access-Control-Allow-Origin' '*';
			add_header Cross-Origin-Opener-Policy same-origin;
			add_header Cross-Origin-Embedder-Policy require-corp;
			add_header Cross-Origin-Resource-Policy same-origin;
				  }
				  
				  
		location /orthanc/{
        
            proxy_pass http://localhost:8042;
            proxy_set_header Authorization "Basic YWxuYXNhcnBhY3MbyybyybNhcnBhY3M1Nzc=";
            proxy_set_header Host $Host:8099/orthanc/;
            proxy_set_header X-Real-IP $remote_addr;
            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
            proxy_set_header X-Forwarded-Host $server_name;

            # CORS Magic
            add_header 'Access-Control-Allow-Origin' '*';
            add_header 'Access-Control-Allow_Credentials' 'true';
            add_header 'Access-Control-Allow-Headers' 'Authorization,Accept,Origin,DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Content-Range,Range';
            add_header 'Access-Control-Allow-Methods' 'GET,POST,OPTIONS,PUT,DELETE,PATCH';
            rewrite /orthanc(.*) $1 break;
                           }     		  
    }
}

My app-config.js is below

window.config = {
    routerBasename: "/",
    extensions: [],
    modes: [],
    customizationService: {},
    showStudyList: !0,
    maxNumberOfWebWorkers: 3,
    omitQuotationForMultipartRequest: !0,
    showWarningMessageForCrossOrigin: !0,
    showCPUFallbackMessage: !0,
    showLoadingIndicator: !0,
    maxNumRequests: {
        interaction: 100,
        thumbnail: 75,
        prefetch: 10
    },
    dataSources: [{
        friendlyName: "dcmjs DICOMWeb Server",
        namespace: "@ohif/extension-default.dataSourcesModule.dicomweb",
        sourceName: "dicomweb",
        configuration: {
            name: "aws",
            wadoUriRoot: '/orthanc/wado',
			qidoRoot: '/orthanc/dicom-web',
			wadoRoot: '/orthanc/dicom-web',
            qidoSupportsIncludeField: !1,
            supportsReject: !1,
            imageRendering: "wadors",
            thumbnailRendering: "wadors",
            enableStudyLazyLoad: !1,
            supportsFuzzyMatching: !1,
            supportsWildcard: !0,
            staticWado: !0,
            singlepart: "bulkdata,video,pdf"
        }
    }, {
        friendlyName: "dicom json",
        namespace: "@ohif/extension-default.dataSourcesModule.dicomjson",
        sourceName: "dicomjson",
        configuration: {
            name: "json"
        }
    }, {
        friendlyName: "dicom local",
        namespace: "@ohif/extension-default.dataSourcesModule.dicomlocal",
        sourceName: "dicomlocal",
        configuration: {}
    }],
    httpErrorHandler: e => {
        console.warn(e.status), console.warn("test, navigate to https://ohif.org/")
    },
    defaultDataSourceName: "dicomweb",
   
};

The current behavior

OHIF V3 with Orthanc MPR functionality works fine on localhost but Error: Uncaught (in promise) Error: SharedArrayBuffer is NOT supported in your browser see https://developer.chrome.com/blog/enabling-shared-array-buffer/ error occurs when accessing over that internet

The expected behavior

It should work over the internet as well as localhost

I tried using the example nginx config file here as a guide >>> https://github.com/OHIF/Viewers/blob/master/.docker/Nginx-Orthanc/config/nginx.conf but no luck.

The text was updated successfully, but these errors were encountered:

ranasrule · 2023-03-07T19:19:54Z

Anyone?

ranasrule · 2023-03-09T10:43:28Z

please?

daker · 2023-04-17T18:23:30Z

have you tried putting the headers inside single quotes ? like this ?

location / {
        try_files $uri /index.html;
        add_header 'Cross-Origin-Embedder-Policy' 'require-corp';
        add_header 'Cross-Origin-Opener-Policy' 'same-origin';
}

ranasrule · 2023-04-18T04:09:08Z

have you tried putting the headers inside single quotes ? like this ?

location / {
        try_files $uri /index.html;
        add_header 'Cross-Origin-Embedder-Policy' 'require-corp';
        add_header 'Cross-Origin-Opener-Policy' 'same-origin';
}

is https required or will this work with simple hppt over the internet ?

daker · 2023-04-18T16:36:41Z

it should work with http

arunjoshtech · 2023-09-02T15:05:53Z

have you tried putting the headers inside single quotes ? like this ?
location / {
        try_files $uri /index.html;
        add_header 'Cross-Origin-Embedder-Policy' 'require-corp';
        add_header 'Cross-Origin-Opener-Policy' 'same-origin';
}
is https required or will this work with simple hppt over the internet ?

Dear Ranasrule,
Have you resolved the issues, I am also facing same issues. Please advise

arunjoshtech · 2023-09-02T15:07:29Z

we tried with with add header but it is not giving result. kindly advise on it to make it work

sedghi · 2023-09-29T13:17:00Z

@jbocce Do you know what is going on here? I believe it is the secure context problem.

jbocce · 2023-09-29T13:25:33Z

@jbocce Do you know what is going on here? I believe it is the secure context problem.

At first glance, I would say that the problem is that a secure context has not been established. So to answer a previous question from @ranasrule, https IS required over the internet.

ranasrule · 2023-09-29T13:31:13Z

Secure context is required not just over the Internet but also over local network. It's only not required on localhost.

…

On Fri, 29 Sept 2023, 6:25 pm Joe Boccanfuso, ***@***.***> wrote: @jbocce <https://github.com/jbocce> Do you know what is going on here? I believe it is the secure context problem. At first glance, I would say that the problem is that a secure context <https://docs.ohif.org/deployment/cors#secure-context> has not been established. So to answer a previous question from @ranasrule <https://github.com/ranasrule>, https IS required over the internet. — Reply to this email directly, view it on GitHub <#3220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGKNOZ4C3UAX23VRMAULLDX43D5PANCNFSM6AAAAAAVRKV7QA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

sedghi · 2023-09-29T13:56:36Z

localhost is secure by design https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts#when_is_a_context_considered_secure

ranasrule · 2023-09-29T15:07:54Z

This really is a terrible decision by the developers as most pacs are used primarily over the local network via their IP addresses hence a secure context it not always possible.

…

On Fri, 29 Sept 2023, 6:56 pm Alireza, ***@***.***> wrote: localhost is secure by design https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts#when_is_a_context_considered_secure — Reply to this email directly, view it on GitHub <#3220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGKNO633W5BZPWR6RQZB2DX43HR5ANCNFSM6AAAAAAVRKV7QA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

sedghi · 2023-09-29T15:23:59Z

You can still use the StackViewport, however, if you want Volume rendering, you should be in a secure context. Just want to point out the decision of ONLY allowing SharedArrayBuffer to run in a secure context is by World Wide Web Consortium group and not OHIF

ranasrule · 2023-09-29T16:17:43Z

But the decision to USE shared buffers was made by the OHIF team. Check out the VolView plugin for Orthanc by Kitware. It manages to provide MPR and 3d reconstruction in the browser without the need for any kind of secure context.

…

On Fri, 29 Sept 2023, 8:24 pm Alireza, ***@***.***> wrote: You can still use the StackViewport, however, if you want Volume rendering, you should be in a secure context. Just want to point out the decision of enabling SharedArrayBuffer in a secure context is by World Wide Web Consortium group and not OHIF — Reply to this email directly, view it on GitHub <#3220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGKNOYTNBS4HJKULQXDO5LX43RZXANCNFSM6AAAAAAVRKV7QA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

sedghi · 2023-09-29T16:20:19Z

You can turn it off but it would be slower, just FYI (maybe I should have mentioned it in the previous reply)

useSharedArrayBuffer here https://docs.ohif.org/configuration/configurationFiles

ps: where is the link to your plugin for volview?

ranasrule · 2023-09-29T19:24:25Z

Please see link below https://book.orthanc-server.com/plugins/volview.html

…

On Fri, Sep 29, 2023 at 9:20 PM Alireza ***@***.***> wrote: You can turn it off but it would be slower, just FYI (maybe I should have mentioned it in the previous reply) useSharedArrayBuffer here https://docs.ohif.org/configuration/configurationFiles ps: where is the link to your plugin for volview? — Reply to this email directly, view it on GitHub <#3220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGKNOYAJBTWGM7RXUGV5VLX43YM3ANCNFSM6AAAAAAVRKV7QA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Regards, Rana Asim Wajid

ranasrule · 2023-09-29T20:11:55Z

You can turn it off but it would be slower, just FYI (maybe I should have mentioned it in the previous reply)

useSharedArrayBuffer here https://docs.ohif.org/configuration/configurationFiles

ps: where is the link to your plugin for volview?

setting useSharedArrayBuffer to false gives the following error even when loading the study in non mpr mode

sedghi · 2023-09-29T21:36:18Z

Check this PR out, it will fix that bug after merge

#3686

ranasrule · 2023-09-30T09:17:07Z

Check this PR out, it will fix that bug after merge

#3686

still getting the same issue even after merging of #3686

sedghi · 2023-10-02T14:39:18Z

There is a very good chance you are saying false (boolean) while it should be string. I have another PR to fix this to support boolean too https://github.com/OHIF/Viewers/pull/3688/files

If you see the memory snapshot there is not sharedArrayBuffer

ranasrule · 2023-10-02T22:52:41Z

@sedghi I have set useSharedArrayBuffer: "FALSE" as you suggest but with the same results as you can see in the screenshots below

One more thing...I have no idea if this has anything to do with the issue under discussion but Im also getting the error in the screenshot below in the browser console:

sedghi · 2023-10-03T00:39:50Z

You are putting it in a wrong location, it should be the root of the configuration

ranasrule · 2023-10-03T02:10:43Z

You are putting it in a wrong location, it should be the root of the configuration

Perfect...working great now. Thank you for all your contributions to this great project.

mrceresa · 2024-02-06T08:52:04Z

Dears,
thanks for all the information provided both here and in the docs.

I have two questions (additional details here):

any way to get a secure context with cors if I have orthanc and ohif on separate domains? As of now when I enable same-origin it stops loading the dicoms
my useSharedArrayBuffer = 'FALSE' seems to be ignored, do you have additional information on how to debug this?

window.config = {
  routerBasename: '/',
...
  useSharedArrayBuffer: 'FALSE',
...

Thanks and regards

sedghi · 2024-02-20T17:02:17Z

@mrceresa see our docs https://docs.ohif.org/deployment/

ranasrule added Awaiting Reproduction Can we reproduce the reported bug? Community: Report 🐛 labels Mar 6, 2023

sedghi removed the Community: Report 🐛 label Jun 23, 2023

sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Oct 2, 2023

sedghi mentioned this issue Oct 3, 2023

Any way to use MPR functionality without HTTPS? #3316

Closed

sedghi closed this as completed Oct 11, 2023

mrceresa mentioned this issue Feb 7, 2024

[Bug] Cannot disable SharedArrayBuffer #3922

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OHIF V3 with Orthanc MPR works fine on localhost but SharedArrayBuffer error over internet #3220

OHIF V3 with Orthanc MPR works fine on localhost but SharedArrayBuffer error over internet #3220

ranasrule commented Mar 6, 2023 •

edited

Loading

ranasrule commented Mar 7, 2023

ranasrule commented Mar 9, 2023

daker commented Apr 17, 2023 •

edited

Loading

ranasrule commented Apr 18, 2023

daker commented Apr 18, 2023

arunjoshtech commented Sep 2, 2023

arunjoshtech commented Sep 2, 2023

sedghi commented Sep 29, 2023 •

edited

Loading

jbocce commented Sep 29, 2023

ranasrule commented Sep 29, 2023 via email

sedghi commented Sep 29, 2023

ranasrule commented Sep 29, 2023 via email

sedghi commented Sep 29, 2023 •

edited

Loading

ranasrule commented Sep 29, 2023 via email •

edited

Loading

sedghi commented Sep 29, 2023

ranasrule commented Sep 29, 2023 via email

ranasrule commented Sep 29, 2023

sedghi commented Sep 29, 2023

ranasrule commented Sep 30, 2023

sedghi commented Oct 2, 2023

ranasrule commented Oct 2, 2023 •

edited

Loading

sedghi commented Oct 3, 2023

ranasrule commented Oct 3, 2023

mrceresa commented Feb 6, 2024

sedghi commented Feb 20, 2024

OHIF V3 with Orthanc MPR works fine on localhost but SharedArrayBuffer error over internet #3220

OHIF V3 with Orthanc MPR works fine on localhost but SharedArrayBuffer error over internet #3220

Comments

ranasrule commented Mar 6, 2023 • edited Loading

Describe the Bug

Steps to Reproduce:

The current behavior

The expected behavior

ranasrule commented Mar 7, 2023

ranasrule commented Mar 9, 2023

daker commented Apr 17, 2023 • edited Loading

ranasrule commented Apr 18, 2023

daker commented Apr 18, 2023

arunjoshtech commented Sep 2, 2023

arunjoshtech commented Sep 2, 2023

sedghi commented Sep 29, 2023 • edited Loading

jbocce commented Sep 29, 2023

ranasrule commented Sep 29, 2023 via email

sedghi commented Sep 29, 2023

ranasrule commented Sep 29, 2023 via email

sedghi commented Sep 29, 2023 • edited Loading

ranasrule commented Sep 29, 2023 via email • edited Loading

sedghi commented Sep 29, 2023

ranasrule commented Sep 29, 2023 via email

ranasrule commented Sep 29, 2023

sedghi commented Sep 29, 2023

ranasrule commented Sep 30, 2023

sedghi commented Oct 2, 2023

ranasrule commented Oct 2, 2023 • edited Loading

sedghi commented Oct 3, 2023

ranasrule commented Oct 3, 2023

mrceresa commented Feb 6, 2024

sedghi commented Feb 20, 2024

ranasrule commented Mar 6, 2023 •

edited

Loading

daker commented Apr 17, 2023 •

edited

Loading

sedghi commented Sep 29, 2023 •

edited

Loading

sedghi commented Sep 29, 2023 •

edited

Loading

ranasrule commented Sep 29, 2023 via email •

edited

Loading

ranasrule commented Oct 2, 2023 •

edited

Loading