Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Integration test wait until rendered/queried instead of timed #3540

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

wayfarer3130
Copy link
Contributor

Context

Added support to directly use the rendered/queried results.

Changes & Results

Use the cornerstone renderedState to wait for dicom image load instead of timing it.
Added a querying parameter to the worklist to record whether a query is in progress or not. Exposed as a data-querying element (this is already re-rendering, so no significant change on render timing).

Testing

Run the integration tests - they should pass (once new CS3D is incorporated)

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@wayfarer3130 wayfarer3130 requested a review from sedghi July 17, 2023 13:03
@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 68886fa
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64b7e46e30bbb9000828d21d

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 68886fa
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64b7e46e71a72e000824eb9c
😎 Deploy Preview https://deploy-preview-3540--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #3540 (68886fa) into master (18156bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3540   +/-   ##
=======================================
  Coverage   42.75%   42.75%           
=======================================
  Files          82       82           
  Lines        1450     1450           
  Branches      338      338           
=======================================
  Hits          620      620           
  Misses        667      667           
  Partials      163      163           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265c1fb...68886fa. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 17, 2023

Passing run #3378 ↗︎

0 36 0 0 Flakiness 0

Details:

Use enum comparison for RENDERED
Project: Viewers Commit: 68886fae3d
Status: Passed Duration: 03:10 💡
Started: Jul 19, 2023 1:31 PM Ended: Jul 19, 2023 1:35 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sedghi
Copy link
Member

sedghi commented Jul 17, 2023

I believe you can derive that state, could you try this

const querying = useMemo(() => {
  return isLoadingData || expandedRows.length > 0; 
}, [isLoadingData, expandedRows]);

@wayfarer3130 wayfarer3130 requested a review from sedghi July 19, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants