Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SR display): and the token based navigation #3995

Merged
merged 2 commits into from
Mar 18, 2024
Merged

fix(SR display): and the token based navigation #3995

merged 2 commits into from
Mar 18, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Mar 18, 2024

will try to fix this

#3928

and the display of the SRs

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 8529d54
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/65f882e86ae4bf00080ca142
😎 Deploy Preview https://deploy-preview-3995--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 8529d54
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/65f882e82adf7e000894d2da
😎 Deploy Preview https://deploy-preview-3995--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.44%. Comparing base (8a335bd) to head (8529d54).
Report is 254 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3995      +/-   ##
==========================================
- Coverage   46.23%   44.44%   -1.80%     
==========================================
  Files          78       80       +2     
  Lines        1276     1332      +56     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      587      +39     
- Partials      138      153      +15     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0881590...8529d54. Read the comment docs.

@sedghi sedghi changed the title fix/bugs 123 fix(SR display): and the token based navigation Mar 18, 2024
@sedghi sedghi merged commit feed230 into master Mar 18, 2024
9 of 11 checks passed
ryan00012 pushed a commit to new-lantern/nl-ohif that referenced this pull request Mar 27, 2024
* chore(version): Update package versions [skip ci]

* feat(displayArea): add display area to hanging protocol (OHIF#3691)

Co-authored-by: Ouwen Huang <ouwen.oh@gmail.com>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(debug): Add timing information about time to first image/all images, and query time (OHIF#3681)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(cli): Add npm packaged mode not working (OHIF#3689)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(translation): Side panel translate fix (OHIF#3156)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(locale): Added Turkish language support (tr-TR) - Community PR (OHIF#3695)

Co-authored-by: Ahmet Altay <46381367+ahmetaltay33@users.noreply.github.com>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(locale): add German translations - community PR (OHIF#3697)

Co-authored-by: pwespi <pwespi@pm.me>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(measurement and microscopy):  various small fixes for measurement and microscopy side panel (OHIF#3696)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(segmentation scroll): and hydration bugs (OHIF#3701)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(bugs): fixing lots of bugs regarding release candidate (OHIF#3700)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(Segmentation): download RTSS from Labelmap(OHIF#3692)

Co-authored-by: Alireza <ar.sedghi@gmail.com>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(segmentation): do not use SAB if not specified (OHIF#3705)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(modality unit): fix the modality unit per target via upgrade of cs3d (OHIF#3706)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(voi): should publish voi change event on reset (OHIF#3707)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(segmentation):  Various fixes for segmentation mode and other (OHIF#3709)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(modules): add stylus loader as an option to be uncommented (OHIF#3710)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(i18n): display set(s) are two words for English messages (OHIF#3711)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(export): wrong export for the tmtv RT function (OHIF#3715)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(display messages): broken after timings (OHIF#3719)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* chore(version): move to the next beta version [BUMP BETA]

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(calibration): No calibration popup caused by perhaps an unused code optimization for production builds (OHIF#3736)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(cine): Use the frame rate specified in DICOM and optionally auto play cine (OHIF#3735)

Co-authored-by: rareramos <rareramos1126@gmail.com>
Co-authored-by: Doug Horner <horner@mieweb.com>
Co-authored-by: Rehan <58819707+Rayhan-011@users.noreply.github.com>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(recipes): package.json script orthanc:up docker-compose path (OHIF#3741)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* docs(azure): Azure static Deployment details (OHIF#3740)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(sr): dcm4chee requires the patient name for an SR to match what is in the original study (OHIF#3739)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(toolbar): allow customizable toolbar for active viewport and allow active tool to be deactivated via a click (OHIF#3608)

Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(measurement service): Implemented correct check of schema keys in _isValidMeasurment. (OHIF#3750)

* feat(filters): save worklist query filters to session storage so that they persist between navigation to the viewer and back (OHIF#3749)

Co-authored-by: ladeirarodolfo <39910206+ladeirarodolfo@users.noreply.github.com>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(i18n): enhanced i18n support (OHIF#3730)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(thumbnail): Avoid multiple promise creations for thumbnails (OHIF#3756)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* docs(faq): FAQ and Segmentation Mode Fix for some studies (OHIF#3762)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(hp callback): Add viewport ready callback (OHIF#3772)

Co-authored-by: Ouwen Huang <ouwen.huang@duke.edu>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat: add VolumeViewport rotation (OHIF#3776)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(arrow): ArrowAnnotate text key cause validation error (OHIF#3771)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(path): upgrade docusaurus for security (OHIF#3780)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(dicomJSON): Add Loading Other Display Sets and JSON Metadata Generation script (OHIF#3777)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(overlay): Overlays aren't shown on undefined origin (OHIF#3781)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix: 🐛 Run error handler for failed image requests (OHIF#3773)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(url): Add SeriesInstanceUIDs wado query param (OHIF#3746)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(docs): Added various training videos to support the OHIF CLI tools (OHIF#3794)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(metadata): to handle cornerstone3D update for htj2k (OHIF#3783)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(DICOM Overlay): The overlay data wasn't being refreshed on change (OHIF#3793)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(events): broadcast series summary metadata (OHIF#3798)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat: Merge Data Source (OHIF#3788)

Add the ability to merge two different series queries to generate a complete study query result.  Provides basic support for other types of merges, but those aren't yet added as full features.

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix: Update the CS3D packages to add the most recent HTJ2K TSUIDS (OHIF#3806)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(cine): Set cine disabled on mode exit. (OHIF#3812)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(SM): drag and drop is now fixed for SM (OHIF#3813)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(auth): fix the issue with oauth at a non root path (OHIF#3840)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(HP): Added new 3D hanging protocols to be used in the new layout selector (OHIF#3844)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(i18n): enhanced i18n support (OHIF#3761)

* fix: address and improve system vulnerabilities (OHIF#3851)

* feat(config): Add activateViewportBeforeInteraction parameter for viewport interaction customization (OHIF#3847)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(customizationService): Enable saving and loading of private tags in SRs (OHIF#3842)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* Fix(HPService): custom image load performed is now reset to false on HP exit (OHIF#3809)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(dicom-seg) : Fix the missing color tag when loading Dicom-Seg (OHIF#3822)

Co-authored-by: Alireza <ar.sedghi@gmail.com>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* docs: Update HangingProtocolService.md doc sameAs example to contain constr… (OHIF#3765)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(overlay): add inline binary overlays (OHIF#3852)

* fix(icon-style): Ensure consistent icon dimensions (OHIF#3727)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* chore(version): upgrade cornerstone3D versions (OHIF#3853)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* chore(version): upgrade cornerstone3D versions to fix orientation (OHIF#3854)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix: colormap for stack viewports via HangingProtocol (OHIF#3866)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix: convert radian to degree value for mip rotation (OHIF#3881)

* fix: PDF display request in v3 (OHIF#3878)

Co-authored-by: Alireza <ar.sedghi@gmail.com>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat: improve disableEditing flag (OHIF#3875)

Co-authored-by: Igor Octaviano <igoroctaviano@gmail.com>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(ui): sidePanel expandedWidth (OHIF#3728)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat: Add on mode init hook (OHIF#3882)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* docs: Update user-account-control.md (OHIF#3877)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(segmentation): upgrade cs3d to fix various segmentation bugs (OHIF#3885)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(transferSyntax): prefer server transcoded transfer syntax for all images (OHIF#3883)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(hp): enable OHIF to run with partial metadata for large studies at the cost of less effective hanging protocol (OHIF#3804)

Co-authored-by: rodrigobasilio2022 <rodrigo.basilio@radicalimaging.com>
Co-authored-by: rodrigobasilio2022 <114958722+rodrigobasilio2022@users.noreply.github.com>

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix: Update CS3D to fix second render (OHIF#3892)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* docs: Update architecture.md (OHIF#3891)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix: 🐛 Check merge key for merge data source (OHIF#3901)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix: is same orientaiton (OHIF#3905)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(viewport-sync): remember synced viewports bw stack and volume and RENAME StackImageSync to ImageSliceSync (OHIF#3849)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix: catch errors in getPTImageIdInstanceMetadata (OHIF#3897)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix toggleHpTools to support split primary button (OHIF#3900)

Fixes a small bug in toggling buttons with hanging protocols.

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix: 🐛 Sort merge results based on default data source (input) (OHIF#3903)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(errorboundary): format stack trace properly (OHIF#3931)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(resize): Optimize resizing process and maintain zoom level (OHIF#3889)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(demo): Deploy issue (OHIF#3951)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(docs): Minor typos in hpModule.md (OHIF#3962)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* docs: Typo (OHIF#3975)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(cli): mode creation template (OHIF#3876) (OHIF#3981)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(delete measurement): icon for measurement table (OHIF#3775)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* fix(SR display): and the token based navigation (OHIF#3995)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

* feat(worklist): New worklist buttons and tooltips (OHIF#3989)

* chore(version): version.json [skip ci]

* chore(version): Update package versions [skip ci]

---------

Co-authored-by: ohif-bot <danny.ri.brown+ohif-bot@gmail.com>
Co-authored-by: Alireza <ar.sedghi@gmail.com>
Co-authored-by: Ouwen Huang <ouwen.oh@gmail.com>
Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
Co-authored-by: Joe Boccanfuso <109477394+jbocce@users.noreply.github.com>
Co-authored-by: wangxuan <wx_0322@163.com>
Co-authored-by: Ahmet Altay <46381367+ahmetaltay33@users.noreply.github.com>
Co-authored-by: pwespi <pwespi@pm.me>
Co-authored-by: dxlin <dxlin@users.noreply.github.com>
Co-authored-by: rareramos <rareramos1126@gmail.com>
Co-authored-by: Doug Horner <horner@mieweb.com>
Co-authored-by: Rehan <58819707+Rayhan-011@users.noreply.github.com>
Co-authored-by: edwardyangxin <yx_yoyo@live.cn>
Co-authored-by: bluesteel23 <132684122+bluesteel23@users.noreply.github.com>
Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com>
Co-authored-by: ladeirarodolfo <39910206+ladeirarodolfo@users.noreply.github.com>
Co-authored-by: Pavel <P.A.Pisarev@yandex.ru>
Co-authored-by: Ouwen Huang <ouwen.huang@duke.edu>
Co-authored-by: Pedro H. Köhler <pedrokohlerbh@gmail.com>
Co-authored-by: Igor Octaviano <igoroctaviano@gmail.com>
Co-authored-by: Sofien-Sellami <73444179+Sofien-Sellami@users.noreply.github.com>
Co-authored-by: Salim Kanoun <salim.kanoun@gmail.com>
Co-authored-by: Celian-abd <101793092+Celian-abd@users.noreply.github.com>
Co-authored-by: AbishekBista9 <133620692+AbishekBista9@users.noreply.github.com>
Co-authored-by: rodrigobasilio2022 <rodrigo.basilio@radicalimaging.com>
Co-authored-by: rodrigobasilio2022 <114958722+rodrigobasilio2022@users.noreply.github.com>
Co-authored-by: Ibrahim <93064150+IbrahimCSAE@users.noreply.github.com>
Co-authored-by: EricB <eric.brayet@free.fr>
Co-authored-by: EricB <ericb@paire.tech>
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants