-
Notifications
You must be signed in to change notification settings - Fork 23
Viewport #24
Conversation
@biharck, can you remove the The main OHIF projects use yarn and commit |
src/classes/HotkeysUtil.js
Outdated
|
||
_dispatchCommand(options) { | ||
const { setActiveViewportSpecificData } = actions | ||
window.store.dispatch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the best/only way to access the store?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I am not 100% sure about it either. We can catch up in order to design the best approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@biharck we should never use window.store
in this package.
We should get a callback and trigger that callback, so let the caller decide what to do with it. See how Hanging Protocol Engine do that.
You added a new Action, which broke a unit test. Can you update the unit test to include the new Action? You can see the error by clicking "Details" next to the integration check. It should take you here: |
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
- Coverage 7.29% 7.22% -0.08%
=========================================
Files 167 167
Lines 4480 4538 +58
Branches 909 913 +4
=========================================
+ Hits 327 328 +1
- Misses 3271 3323 +52
- Partials 882 887 +5
Continue to review full report at Codecov.
|
🎉 This PR is included in version 0.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adding the ability to use hotkeys with: