pgsql: remove unused msg field (7.0.x backport) - v1

[jufajardini]

The ConsolidatedDataRow struct had a length field that wasn't truly used.

Related to
Bug #6389

(cherry-picked from commit 1afb485)

Link to redmine ticket:

• backport ticket: https://redmine.openinfosecfoundation.org/issues/6521
• original ticket: https://redmine.openinfosecfoundation.org/issues/6389

Describe changes:

• Backport of pgsql: remove unused msg field - v1 #10062 with clean cherry-pick

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8f3753) 82.45% compared to head (067ca94) 82.41%.

Additional details and impacted files

@@              Coverage Diff               @@
##           main-7.0.x   #10079      +/-   ##
==============================================
- Coverage       82.45%   82.41%   -0.04%     
==============================================
  Files             969      969              
  Lines          273937   273935       -2     
==============================================
- Hits           225870   225763     -107     
- Misses          48067    48172     +105     

Flag	Coverage Δ
fuzzcorpus	64.22% <ø> (-0.10%)	⬇️
suricata-verify	61.08% <ø> (-0.04%)	⬇️
unittests	62.93% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[suricata-qa]

WARNING:

field	baseline	test	%
	SURI_TLPW2_autofp_stats_chk
.uptime	188	200	106.38%

Pipeline 17155

[inashivb]

This looks like a cleanup to me. I wonder why is this being backported? And, how does it relate to the linked ticket?

[jufajardini]

This looks like a cleanup to me. I wonder why is this being backported? And, how does it relate to the linked ticket?

Fair. It relates to the linked ticket because the work done for the ticket will impact this field. And since it's a field that's not truly used, seemed to make sense to remove it...

[victorjulien]

Merged in #10081, thanks!