Clippy fixes v2 #10124
Closed
Clippy fixes v2 #10124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which will be optimized away by the compiler
using panic! instead with a string message
Coming from old test_case crate
warning: unneeded unit expression
--> src/bittorrent_dht/parser.rs:590:5
|
590 | / #[test_case(
591 | | b"",
592 | | "Error: discovered Dict but expected EOF" ;
593 | | "test parse bittorrent dht packet err 1"
594 | | )]
| |______^
warning: this is a decimal constant
--> src/mqtt/parser.rs:888:19
|
888 | 0x00, 06, /* Topic Length: 6 */
| ^^
|
warning: calls to `push` immediately after creation
--> src/pgsql/parser.rs:1179:9
|
1179 | / let mut database_param: Vec<PgsqlParameter> = Vec::new();
1180 | | database_param.push(database);
| |______________________________________^
help: consider using the `vec![]` macro: `let database_param: Vec<PgsqlParameter> = vec![..];`
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/http2/parser.rs:882:17
|
882 | / match ctx.value {
883 | | Some(_) => {
884 | | panic!("Unexpected value");
885 | | }
886 | | None => {}
887 | | }
| |_________________^
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10124 +/- ##
==========================================
+ Coverage 82.15% 82.16% +0.01%
==========================================
Files 974 974
Lines 271925 271856 -69
==========================================
- Hits 223394 223373 -21
+ Misses 48531 48483 -48
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
reviewed
Jan 5, 2024
Comment on lines
+228
to
232
| if let Some(txp) = parse_tftp_request(&READ_REQUEST[..]) { | ||
| assert_eq!(tx, txp); | ||
| } else { | ||
| panic!("Result should not be None"); | ||
| } |
There was a problem hiding this comment.
In tests I prefer:
let txp = parse_tftp_request(&READ_REQUEST[..]).unwrap();
assert_eq!(tx, txp);
jasonish
reviewed
Jan 5, 2024
Comment on lines
+641
to
645
| if let Ok((_, val)) = parse_bytemath("bytes 4, offset 3933, oper +, rvalue myrvalue, result foo, string hex") { | ||
| assert_eq!(val, bmd); | ||
| } else { | ||
| panic!("Result shoud be ok"); | ||
| } |
jasonish
reviewed
Jan 5, 2024
Comment on lines
+413
to
415
| if parser::parse_dcerpc_udp_header(request).is_ok() { | ||
| panic!("Result shoud not be ok"); | ||
| } |
There was a problem hiding this comment.
assert!(parser::parser_dcerpc_udp_header(request).is_err());
jasonish
requested changes
Jan 5, 2024
|
Information: QA ran without warnings. Pipeline 17375 |
Closed
|
Replaces by #10129, thanks Jason for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None
Describe changes:
@jasonish why do I get these and CI is not red ?
Is this because the lint level to deny warnings does not apply to test code ?
#10113 rebased and more commits
Only 19 match_single_binding warnings remaining