Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: move detect http.uri tests to suricata-verify #11315

Closed

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/3725

Describe changes:

  • move some unit tests to suricata-verify : ones about http.uri detection

Thay all follow the same basis :

  • have one rule
  • have one or 2 HTTP requests buffers
  • check if the rule triggered on each of these buffers

SV_BRANCH=OISF/suricata-verify#1919

#11307 without messy commit (that helps create SV tests and is available in previous PR) and with more tests converted (ie the DetectEngineHttpRawUriTest ones)

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.40%. Comparing base (49ecf37) to head (57e9e64).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11315      +/-   ##
==========================================
- Coverage   82.47%   82.40%   -0.08%     
==========================================
  Files         934      934              
  Lines      252270   247296    -4974     
==========================================
- Hits       208055   203776    -4279     
+ Misses      44215    43520     -695     
Flag Coverage Δ
fuzzcorpus 60.26% <ø> (ø)
livemode 18.76% <ø> (+<0.01%) ⬆️
pcap 43.78% <ø> (+0.01%) ⬆️
suricata-verify 61.31% <ø> (-0.01%) ⬇️
unittests 59.32% <ø> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21111

@victorjulien victorjulien added this to the 8.0 milestone Jun 18, 2024
@victorjulien
Copy link
Member

Merged in #11326, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants