-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/nom7 nfs v0.1 #6589
Dev/nom7 nfs v0.1 #6589
Conversation
The `count` combinator preallocates a number of bytes. Since the value is untrusted, this can result in an Out Of Memory allocation. Use a maximum value, large enough to cover all current implementations.
Additional note: there is one tricky part in |
Codecov Report
@@ Coverage Diff @@
## master #6589 +/- ##
=======================================
Coverage 77.07% 77.07%
=======================================
Files 613 613
Lines 186207 186207
=======================================
+ Hits 143513 143525 +12
+ Misses 42694 42682 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged in #6629, thanks! |
In our conf.py we reference some ReadTheDocs stylesheets that appear to be old and break formatting of some items like bulletted lists. Bug: OISF#6589
In our conf.py we reference some ReadTheDocs stylesheets that appear to be old and break formatting of some items like bulletted lists. Bug: OISF#6589
In our conf.py we reference some ReadTheDocs stylesheets that appear to be old and break formatting of some items like bulletted lists. Bug: OISF#6589
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4165
Describe changes:
Notes:
count
combinator in 4f25d49, since this combinator preallocates data based on a value from the packet, and so can easily be used to trigger an OOM (reported to nom as Provide acount
-like combinator, without preallocation rust-bakery/nom#1459)