stream-tcp-reassemble: fix reassembly direction for FIN packets #6686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suricata invokes the stream reassembly logic only for the current packet direction if the packet contains a FIN flag. However, this does not handle the case in which the packet ACKs data from the opposing direction. This patch forces the invocation of the stream reassembly logic on both direction when Suricata sees a FIN packet.
inashivb
reviewed
Dec 9, 2021
| dir = UPDATE_DIR_BOTH; | ||
| } else { | ||
| dir = UPDATE_DIR_PACKET; | ||
| } |
There was a problem hiding this comment.
Hi @amirabell ! Thank you for your work! :)
formatting seems to be off here. Could you please check?
There was a problem hiding this comment.
I am sorry, I didn't notice. Opened a new PR: #6693
lukashino
added a commit
to lukashino/suricata
that referenced
this pull request
Jan 16, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Jan 16, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Mar 2, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Mar 11, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 9, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 11, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 11, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 14, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 14, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 14, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 14, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 14, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 28, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 28, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 28, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 29, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 30, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Jun 3, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Jun 8, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Jun 8, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Jun 8, 2024
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Jun 8, 2024
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suricata invokes the stream reassembly logic only for the current packet
direction if the packet contains a FIN flag. However, this does not
handle the case in which the packet ACKs data from the opposing direction.
This patch forces the invocation of the stream reassembly logic
on both direction when Suricata sees a FIN packet.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4877
Describe changes:
-Set direction to UPDATE_DIR_BOTH FIN-ACK packets
#suricata-verify-pr:OISF/suricata-verify#599
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:
Previous PR: #6685