detect/proto/v3: remove unittests #6857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is reimplemented in Suricata-Verify Task: 4911
This was referenced Jan 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #6857 +/- ##
==========================================
- Coverage 77.68% 77.68% -0.01%
==========================================
Files 628 628
Lines 187254 187232 -22
==========================================
- Hits 145473 145448 -25
- Misses 41781 41784 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
|
Merged in #6861, thanks! |
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
May 13, 2024
Implement special "isset" and "isnotset" modes. "isset" matches if an IP address is part of an iprep category with any value. It is internally implemented as ">=,0", which should always be true if there is a value to evaluate, as valid reputation values are 0-127. "isnotset" matches if an IP address is not part of an iprep category. It is internally stored as "=,255", but has some special case handling in the `DetectIPRepMatch` function. Ticket: OISF#6857.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
May 16, 2024
Implement special "isset" and "isnotset" modes. "isset" matches if an IP address is part of an iprep category with any value. It is internally implemented as ">=,0", which should always be true if there is a value to evaluate, as valid reputation values are 0-127. "isnotset" matches if an IP address is not part of an iprep category. It is internally stored as "=,255", but has some special case handling in the `DetectIPRepMatch` function. Ticket: OISF#6857.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jun 6, 2024
Implement special "isset" and "isnotset" modes. "isset" matches if an IP address is part of an iprep category with any value. It is internally implemented as ">=,0", which should always be true if there is a value to evaluate, as valid reputation values are 0-127. "isnotset" matches if an IP address is not part of an iprep category. Internally it is implemented outside the uint support. Ticket: OISF#6857.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jun 15, 2024
Implement special "isset" and "isnotset" modes. "isset" matches if an IP address is part of an iprep category with any value. It is internally implemented as ">=,0", which should always be true if there is a value to evaluate, as valid reputation values are 0-127. "isnotset" matches if an IP address is not part of an iprep category. Internally it is implemented outside the uint support. Ticket: OISF#6857.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jul 1, 2024
Implement special "isset" and "isnotset" modes. "isset" matches if an IP address is part of an iprep category with any value. It is internally implemented as ">=,0", which should always be true if there is a value to evaluate, as valid reputation values are 0-127. "isnotset" matches if an IP address is not part of an iprep category. Internally it is implemented outside the uint support. Ticket: OISF#6857. (cherry picked from commit 83976a4)
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jul 5, 2024
Implement special "isset" and "isnotset" modes. "isset" matches if an IP address is part of an iprep category with any value. It is internally implemented as ">=,0", which should always be true if there is a value to evaluate, as valid reputation values are 0-127. "isnotset" matches if an IP address is not part of an iprep category. Internally it is implemented outside the uint support. Ticket: OISF#6857. (cherry picked from commit 83976a4)
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jul 7, 2024
Implement special "isset" and "isnotset" modes. "isset" matches if an IP address is part of an iprep category with any value. It is internally implemented as ">=,0", which should always be true if there is a value to evaluate, as valid reputation values are 0-127. "isnotset" matches if an IP address is not part of an iprep category. Internally it is implemented outside the uint support. Ticket: OISF#6857. (cherry picked from commit 83976a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4911
Previous PR: #6828
Describe changes:
suricata-verify-pr: 677