Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce theme provider #1300

Merged
merged 11 commits into from
Dec 16, 2021
Merged

feat: introduce theme provider #1300

merged 11 commits into from
Dec 16, 2021

Conversation

thisislawatts
Copy link
Collaborator

@thisislawatts thisislawatts commented Dec 8, 2021 •
edited
Loading

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Supports multiple themes for the Platform, allowing different instances to specify their own PlatformTheme. At the moment this defintion covers:

  • Styling
  • Image assets, eg. Logo/Loader
  • Short snippets of text

@thisislawatts thisislawatts self-assigned this Dec 8, 2021
@cypress
Copy link

cypress bot commented Dec 8, 2021 •
edited
Loading


Test summary

70 • 0 • 0 • 0 • Flakiness 1

Run details
Project onearmy-community-platform
Status Passed
Commit 76ed805
Started Dec 16, 2021 7:34 PM
Ended Dec 16, 2021 7:39 PM
Duration 04:41 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

src/integration/sign-up.spec.ts 1 Flakiness
1 [Sign-up - new user] > sign in as new user

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrismclarke chrismclarke mentioned this pull request Dec 9, 2021
Closed
5 tasks
@davehakkens davehakkens added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Dec 9, 2021
@thisislawatts thisislawatts mentioned this pull request Dec 10, 2021
Merged
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2021 •
edited
Loading

Visit the preview URL for this PR (updated for commit 76ed805):

https://onearmy-next--pr1300-feat-introduce-theme-cq1zetfe.web.app

(expires Sat, 15 Jan 2022 19:34:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@thisislawatts thisislawatts marked this pull request as ready for review December 16, 2021 19:41
davehakkens
davehakkens approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@davehakkens davehakkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i couldn't wait until tomrrow 🤓

@davehakkens davehakkens merged commit ef8bbe3 into master Dec 16, 2021
@davehakkens davehakkens deleted the feat/introduce-theme-provider branch December 16, 2021 21:30
@thisislawatts
Copy link
Collaborator Author

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davehakkens davehakkens davehakkens approved these changes

Assignees

@thisislawatts thisislawatts

Labels
Mod: Events 🎉 Mod: HowTo 📰 Mod: Maps 🗺 Mod: Research 🔬 released Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview 🐣 Second Instance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisislawatts @davehakkens