Merge pull request #738 from ONLYOFFICE/feature/nc-25

Release/7.6.8

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## 7.6.8
+## Changed
+- fix download permission
+
 ## 7.6.6
 ## Added
 - Dutch translation

appinfo/info.xml

@@ -6,7 +6,7 @@
     <description>ONLYOFFICE connector allows you to view, edit and collaborate on text documents, spreadsheets and presentations within Nextcloud using ONLYOFFICE Docs. This will create a new Edit in ONLYOFFICE action within the document library for Office documents. This allows multiple users to co-author documents in real time from the familiar web interface and save the changes back to your file storage.</description>
     <licence>apache</licence>
     <author mail="dev@onlyoffice.com" homepage="https://www.onlyoffice.com/">Ascensio System SIA</author>
-    <version>7.6.6</version>
+    <version>7.6.8</version>
     <namespace>Onlyoffice</namespace>
     <types>
         <prevent_group_restriction/>

controller/editorapicontroller.php

@@ -377,7 +377,8 @@ public function config($fileId, $filePath = null, $shareToken = null, $directTok
             if (method_exists(IShare::class, "getAttributes")) {
                 $share = empty($share) ? $fileStorage->getShare() : $share;
                 $attributes = $share->getAttributes();
-                if ($attributes !== null && !$attributes->getAttribute("permissions", "download")) {
+                $downloadAttr = isset($attributes) ? $attributes->getAttribute("permissions", "download") : null;
+                if (isset($downloadAttr) && !$downloadAttr) {
                     $canDownload = false;
                 }
             }

controller/editorcontroller.php

@@ -1053,7 +1053,8 @@ public function download($fileId, $toExtension = null, $template = false) {
             if (method_exists(IShare::class, "getAttributes")) {
                 $share = empty($share) ? $fileStorage->getShare() : $share;
                 $attributes = $share->getAttributes();
-                if ($attributes !== null && !$attributes->getAttribute("permissions", "download")) {
+                $downloadAttr = isset($attributes) ? $attributes->getAttribute("permissions", "download") : null;
+                if (isset($downloadAttr) && !$downloadAttr) {
                     return $this->renderError($this->trans->t("Not permitted"));
                 }
             }