This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
488 - Add latest date validation for date answers #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tgandrews
force-pushed
the
488-latest-date-validation
branch
from
September 17, 2018 12:15
f52ebaf
to
4c35cf7
Compare
tgandrews
force-pushed
the
488-latest-date-validation
branch
from
September 17, 2018 12:28
4c35cf7
to
9ac2208
Compare
2 tasks
adammahmood
suggested changes
Sep 18, 2018
}, | ||
relativePosition: "After" | ||
}; | ||
expect(JSON.parse(JSON.stringify(result))).toMatchObject(expected); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be simplified to: expect(result).toMatchObject(expected);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works if the test passes but if the objects don't match then you can get jestjs/jest#6730
This makes the error more readable when the test fails. I have added a comment and a tech debt ticket. https://trello.com/c/Ho4Rh8MH/333-resolver-tests-can-trigger-bug-in-jest
tgandrews
force-pushed
the
488-latest-date-validation
branch
from
September 18, 2018 14:26
9ac2208
to
aadc4b8
Compare
adammahmood
approved these changes
Sep 18, 2018
samiwel
approved these changes
Sep 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Adds the ability to hold latest date validations against date answers.
How to review
Reading
Given you have a date answer with an ID of 19
Input:
Updating
Given you have an latest date validation with ID 35
Input:
Dependencies