Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styled-components in group default to the latest version 🚀 #59

Closed

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Nov 28, 2018

The dependency styled-components was updated from 3.4.10 to 4.1.2.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Find out more about this release.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@adammahmood
Copy link
Contributor

This requires some minor refactoring to upgrade.

See: https://www.styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v4

@adammahmood adammahmood added the bug Something isn't working label Dec 5, 2018
@adammahmood adammahmood force-pushed the greenkeeper/default/styled-components-4.1.2 branch from 75ec11f to bfea31d Compare December 12, 2018 09:45
greenkeeper bot added a commit that referenced this pull request Dec 17, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Dec 17, 2018

Update to this version instead 🚀

@tgandrews
Copy link
Contributor

This has some issues:

  1. Not supported by jest-styled-components for assertions. Bring compatibility with v4 styled-components/jest-styled-components#191
  2. For some reason shallow rendering a styled-component loses the name and it appears as ForwardRef supposedly this has been fixed in displayName set on forwardRef is not honored enzymejs/enzyme#1810 but updating all the dependencies does not seem to solve it. This needs more investigation.

@adammahmood
Copy link
Contributor

adammahmood commented Jan 8, 2019

Upgrade to be tackled a later date. Ticket added to Trello.
https://trello.com/c/Zz9M8T8s/97-upgrade-styled-components-to-v4

@adammahmood adammahmood closed this Jan 8, 2019
@jonnyshaw89 jonnyshaw89 deleted the greenkeeper/default/styled-components-4.1.2 branch January 11, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants