This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix #1324 pipenv requirements script #1327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2017 10:34
'pipenv lock -r' outputs a list of dependencies suitable for piping to requirements.txt file but it tends to include all (including dev) dependencies. This is expected behaviour and unlikely to change in Pipenv project but we can work around this by using the Pipenv API to generate our own requirements.txt file (with hashes). Fixes: #1324
|
Latest version of Pipenv doesn't have this issue thanks to https://github.com/kennethreitz/pipenv/pull/972 |
|
Closing as this is fixed in latest version of Pipenv. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
The dev dependencies should not be included in the requirements.txt when the app is deployed.
pipenv lock -ralso includes dev dependencies. This script is a work-around to only include (hashed) production dependencies in requirements.txt (to be used on Jenkins for EB build).NB: Jenkins build for "Deploy Survey Runner to Elastic Beanstalk" will need its config updated to run this new script in place of the
pipenv lock -r...line.Inspired by https://github.com/kennethreitz/pipenv/issues/245#issuecomment-283694215
Fixes: #1324