Feature/epo 733 #147
Merged
Feature/epo 733 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costezki
approved these changes
Apr 26, 2023
| <xd:doc> | ||
| <xd:desc>Checks regex for prefix</xd:desc> | ||
| <xd:param name="element"/> | ||
| <xd:param name="name"/> |
| <xsl:param name="element"/> | ||
| <xsl:variable name="localSegment" select="f:getLocalSegmentForElements($element)"/> | ||
| <xsl:param name="name"/> | ||
| <xsl:variable name="localSegment" select="f:getLocalSegment($name)"/> |
| <xsl:param name="tagName"/> | ||
| <xsl:sequence | ||
| select=" | ||
| if (fn:matches($tagName, '^(:\w+|[a-z][-a-z0-9]*:[-a-zA-Z0-9_@]+)$')) then |
There was a problem hiding this comment.
ummm, ce aveam in minte e ca se aplica toate checkerele de nume la tag:name.
| </xsl:call-template> | ||
| <xsl:call-template name="co-missingNamePrefix"> | ||
| <xsl:with-param name="connector" select="."/> | ||
| </xsl:call-template> |
There was a problem hiding this comment.
I wonder if we can leverage the power of select=".".
We don't need to, but I see this as a convenient and powerful mechanism that you implemented.
So lower level logic can be unified and the variations handled at this level.
| [connectors-with-same-name-multiplicity-68] | ||
| [connectors-with-same-name-definition-69] | ||
| [connectors-with-same-name-definition-70]</xd:desc> | ||
| [connectors-with-same-name-multiplicity-1] |
There was a problem hiding this comment.
I hope you follow a consistent logic with this numbering, also in teh worksheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.