added checkers and imports #162
Conversation
| @@ -37,6 +37,19 @@ | |||
| <xsl:sequence select="$root//elements/element[@name=$name]"/> | |||
| </xsl:function> | |||
|
|
|||
| <xd:doc> | |||
| <xd:desc>fetch the element attribute with a given name</xd:desc> | |||
There was a problem hiding this comment.
Surprisingly, we did not have this before.
don't we check the multiple usage of attributes like we check multipel usage of connectors?
If not then please signal this to Csongor and implement accordingly in the Convention's checking report.
There was a problem hiding this comment.
This is a fetcher for the an element type attribute. The logic for multiple usage is in conventions scripts not helper functions.
| @@ -89,6 +89,10 @@ | |||
| <xsl:call-template name="namePlural"> | |||
| <xsl:with-param name="element" select="."/> | |||
| </xsl:call-template> | |||
| <xsl:call-template name="elementUniqueName"> | |||
| <xsl:with-param name="element" select="."/> | |||
| <xsl:with-param name="isAttribute" select="fn:true()"/> | |||
There was a problem hiding this comment.
What "isAttribute"? The variable name is not clear.
There was a problem hiding this comment.
A flag to tell if the element is an attribute as the logic is different.
Is the element given as a parameter for the template elementUniqueName an attribute ?
| @@ -90,12 +90,13 @@ | |||
| <xsl:call-template name="nonPublicElement"> | |||
| <xsl:with-param name="element" select="."/> | |||
| </xsl:call-template> | |||
| <xsl:call-template name="elementUniqueName"> | |||
| <xsl:with-param name="element" select="."/> | |||
| <xsl:with-param name="isAttribute" select="fn:false()"/> | |||
| @@ -215,7 +216,7 @@ | |||
|
|
|||
|
|
|||
|
|
|||
| <xd:doc> | |||
| <!-- <xd:doc> | |||
There was a problem hiding this comment.
How come this is commented out? What does this mean?
If we do not need this functionality, then delete it. But judging by the documentation, it seems relevant.
There was a problem hiding this comment.
as seen in the changes for this file this functionality was replaced by the new template elementUniqueName. It is commented out and not deleted just in case someone will want to revert the changes made in this pull request
There was a problem hiding this comment.
as seen in the changes for this file this functionality was replaced by the new template elementUniqueName. It is commented out and not deleted just in case someone will want to revert the changes made in this pull request
| <xsl:sequence | ||
| select=" | ||
| if (count($connectorsFound) > 0) then | ||
| f:generateHtmlError(fn:concat('The connector role name ', $targetRole, ' is used in other connectors.')) |
There was a problem hiding this comment.
Should we not tell where else is the connector name used (Source -> Target Classes)?
| <!-- End of common checkers rules --> | ||
| <xsl:call-template name="elementUniqueName"> | ||
| <xsl:with-param name="element" select="."/> | ||
| <xsl:with-param name="isAttribute" select="fn:false()"/> |
There was a problem hiding this comment.
missing documentation on this checker
| <xsl:call-template name="objectUniqueName"> | ||
|
|
||
| <!-- <xsl:call-template name="objectUniqueName"> |
| @@ -145,7 +149,7 @@ | |||
| </xsl:choose> | |||
| </xsl:template> | |||
|
|
|||
| <xd:doc> | |||
| <!-- <xd:doc> | |||
| @@ -63,6 +63,7 @@ | |||
| <xsl:for-each select="$namespacePrefixes/*:prefixes/*:prefix/@importURI"> | |||
| <owl:imports rdf:resource="{.}"/> | |||
| </xsl:for-each> | |||
| <owl:imports rdf:resource="{$coreArtefactURI}"/> | |||
There was a problem hiding this comment.
looks like we have the correct variable name.
Here however we shall add also the "restrictions layer artefact".
No description provided.