-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ted 588 #218
Feature/ted 588 #218
Conversation
Codecov Report
@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 98.70% 98.66% -0.05%
==========================================
Files 115 108 -7
Lines 5030 4864 -166
==========================================
- Hits 4965 4799 -166
Misses 65 65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks decent. BUT way too many files in the PR.
It seems that this PR shall have been split into three:
- implementation of the SPARL validation summarisation
- refactoring/cleanup of the logger
- implementation of the "replace-digest-url" service
@@ -8,8 +8,7 @@ | |||
EventWriterToMongoDBHandler | |||
from ted_sws.event_manager.adapters.event_handler_config import CLILoggerConfig | |||
from ted_sws.event_manager.adapters.event_logger import EventLogger | |||
from ted_sws.event_manager.adapters.log import SeverityLevelType | |||
from ted_sws.event_manager.adapters.logger import LOG_ERROR_TEXT, LOG_SUCCESS_TEXT | |||
from ted_sws.event_manager.adapters.log import SeverityLevelType, LOG_ERROR_TEXT, LOG_SUCCESS_TEXT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module seems to be something that belongs to the entry points, not adapters
from ted_sws import config | ||
|
||
|
||
def update_digest_api_address_for_mapping_suite(mapping_suite: MappingSuite, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good documentation.
SonarCloud Quality Gate failed. |
No description provided.