Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend publishing logic and add Airflow Config resolver for SFTP and … #333

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

CaptainOfHacks
Copy link
Collaborator

…S3 bucket

@swarmia
Copy link

swarmia bot commented Oct 31, 2022

Copy link
Contributor

@kaleanych kaleanych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 PRs strike in a row

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 99.00% // Head: 99.11% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (6d2d912) compared to base (15a3261).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   99.00%   99.11%   +0.11%     
==========================================
  Files         119      119              
  Lines        6000     6000              
==========================================
+ Hits         5940     5947       +7     
+ Misses         60       53       -7     
Impacted Files Coverage Δ
ted_sws/core/adapters/config_resolver.py 75.00% <50.00%> (+15.90%) ⬆️
..._sws/notice_publisher/services/notice_publisher.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CaptainOfHacks CaptainOfHacks merged commit 1b7da71 into main Oct 31, 2022
@CaptainOfHacks CaptainOfHacks deleted the feature/TED-781 branch October 31, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants