-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ted 896 #345
Feature/ted 896 #345
Conversation
✅ Linked to TED-896 · Why the validation summarisation generates empty summaries |
Codecov ReportBase: 99.11% // Head: 99.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 99.11% 99.04% -0.08%
==========================================
Files 119 119
Lines 6000 6048 +48
==========================================
+ Hits 5947 5990 +43
- Misses 53 58 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that the validation bug shall touch on fewer files than this.
Probably there are multiple issues implemented by this PR
@@ -19,7 +19,8 @@ | |||
DEFAULT_NUBER_OF_CELERY_WORKERS = 144 | |||
NOTICE_PROCESS_WORKFLOW_DAG_NAME = "notice_process_workflow" | |||
DEFAULT_START_WITH_TASK_ID = "notice_normalisation_pipeline" | |||
DEFAULT_PIPELINE_NAME_FOR_LOGS = "unknown_pipeline_name" | |||
DEFAULT_PIPELINE_NAME_FOR_LOGS = "unknown_pipeline_name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is merged from main. ask Stefan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge main into current branch, before merge into main.
SonarCloud Quality Gate failed. |
No description provided.